fix(file-store): FileStore contract on local, AWS_REGION on s3, and doc corrections

[saby1101]

Fixes #7, #8 and #9 — the pre-existing bugs surfaced while writing exhaustive branch coverage in #6 — plus the stale documentation that PR left behind. No version bump here.

Based on chore/fastify-plugin-6, not main, since it builds on that branch's tests. Retarget to main once #6 merges.

#7 — LocalFileStore contract

exists rejected on a missing file instead of returning false, diverging from all four other providers and breaking callers written against exists(): Promise<boolean> — wms panel-gateway/src/plugin-reports/reports.route.ts:169 could never reach its not-found branch. Now catches ENOENT and returns false, rethrowing anything else.

save wrote directly while its siblings copyFromStream and copyFromLocalFile both mkdir(dirname, { recursive: true }) first, so nested keys threw ENOENT. wms saves to nested keys throughout (media/…, reports/…). Now mkdirs to match.

The old behaviour was pinned by a test that documented the bug — file-store.spec.ts asserted rejects.toThrow() with the comment "The current implementation throws for non-existent files, so test that". That assertion now checks the contract.

#8 — AWS_REGION was silently ignored

ConfigureAWS always passed region explicitly, so the SDK's own resolution chain never ran — and that chain is what reads the conventional AWS_REGION/AWS_DEFAULT_REGION. A pod configured the standard way silently got us-east-1 and cross-region requests, with no error. Now AWS_S3_REGION ?? AWS_REGION ?? "us-east-1", with README.md updated to document the precedence.

That the pre-existing spec set AWS_REGION against code which never read it suggests this had already caught someone.

#9 — S3 tidy-up

• S3.NoSuchKey → S3.NotFound in exists and getInfo. NoSuchKey is modelled on GetObject (GetObjectCommand.d.ts:297) while HeadObject throws NotFound (HeadObjectCommand.d.ts:271), so those arms could never match. The $metadata 404 check kept as the fallback.
• getInfo missing-timestamp fallback new Date() → new Date(0). Worth noting ISSUES.md records LOW-02 as already having made this exact change for Azure and GCP in 96d40d4 — S3 was simply missed, so this completes it rather than introducing a new convention.
• ConfigureAWS validates S3_BUCKET before constructing the client, matching ConfigureMinio.

Documentation

CLAUDE.md still described the event-bus plugin removed in c001efc, including test:rabbitmq / test:integration / test:all scripts that package.json does not define. .claude/skills/gen-test/SKILL.md instructed agents to use testcontainers, which #6 removes — an active trap for the next agent. Both now describe the lazy SDK loading and the ts-jest sourceMap override, since either is easy to undo by accident and the second silently corrupts coverage numbers.

.claude/skills/release/SKILL.md claimed pushing to main triggers publishing; the workflow runs on: release: [created]. It now also records that version bumps belong on main rather than in a feature PR, and that tags come from the release — the convention this PR pair had to be rebuilt to respect.

pnpm-workspace.yaml still permitted build scripts for cpu-features, protobufjs and ssh2, all of which arrived via testcontainers and are now absent from the tree.

Verification

127 tests (up from 121), 100% coverage held on statements, branches, functions and lines. Each fix has a regression test that fails if reverted. Confirmed against the built dist/:

exists(missing)   -> false        (was: THREW ENOENT)
save("a/b/c.txt") -> ok           (was: THREW ENOENT)
AWS_REGION        -> eu-central-1 (was: us-east-1)

exists and the timestamp fallback are behaviour changes. Both move toward the documented interface and away from provider-specific surprises, but they are visible to anyone who had coded around the old behaviour.

Local issue tracking removed

ISSUES.md is deleted — issues are tracked on GitHub. Its one open finding (MED-01: src/types.ts does not augment FastifyInstance with FileStore) is filed as #11, including the wms declaration-merge risk that has kept it unfixed: wms already declares that exact property at libraries/framework/src/index.ts:58, so the augmentation needs verifying against a real wms build before it ships. The rest of the file was audit history, which belongs in issue threads and resolving PRs. CLAUDE.md records the convention.