Repository navigation
ci: run tests on every pull request - #13
Merged
Merged
Conversation
A stacked PR based on another feature branch reported no checks at all. That is worse than a failure: a required status check that never reports counts as pending, so enabling required checks would block such a PR permanently with nothing to fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for adding a required-status-check rule. This commit was part of #12 but landed after that PR was merged, so it did not make it in.
test.ymltriggers onpull_request: branches: ["main"], so a PR based on another feature branch runs no workflow at all. Both #10 and #12 sat at "no checks reported" for exactly this reason while they were stacked.That is worse than a failing check. GitHub counts a required status check that never reports as pending, not failed — so with required checks enabled, a stacked PR would be blocked permanently, with no failure to fix and no way to satisfy the rule short of retargeting.
Dropping the branch filter costs one extra workflow run per stacked PR and removes that trap.