Skip to content

fix: pass reusable workflow input from event #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Aug 5, 2026
+14 −3
Merged

fix: pass reusable workflow input from event #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/scripts/test-cve-remediation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
FILTER="$SCRIPT_DIR/filter-unlinked-cve-issues.jq"
DISCOVERY_SCRIPT="$SCRIPT_DIR/find-unlinked-cve-issues.sh"
WORKFLOW_FILE="$SCRIPT_DIR/../workflows/_cve-remediation.yml"
CALLER_WORKFLOW_FILE="$SCRIPT_DIR/../workflows/cve-remediation.yml"

assert_json() {
local description="$1"
Expand All @@ -22,8 +23,9 @@ assert_json() {
assert_workflow_contains() {
local description="$1"
local expected="$2"
local workflow_file="${3:-$WORKFLOW_FILE}"

if ! grep -Fq -- "$expected" "$WORKFLOW_FILE"; then
if ! grep -Fq -- "$expected" "$workflow_file"; then
echo "FAIL: $description"
echo "Expected workflow to contain: $expected"
exit 1
Expand All @@ -33,8 +35,9 @@ assert_workflow_contains() {
assert_workflow_not_contains() {
local description="$1"
local unexpected="$2"
local workflow_file="${3:-$WORKFLOW_FILE}"

if grep -Fq -- "$unexpected" "$WORKFLOW_FILE"; then
if grep -Fq -- "$unexpected" "$workflow_file"; then
echo "FAIL: $description"
echo "Expected workflow not to contain: $unexpected"
exit 1
Expand Down Expand Up @@ -276,5 +279,13 @@ assert_workflow_not_contains \
assert_workflow_not_contains \
"does not use unavailable job workflow SHA context" \
'job.workflow_sha'
assert_workflow_contains \
"passes a numeric manual or scheduled issue limit through an allowed context" \
"fromJSON(github.event.inputs.max_issues || '50')" \
"$CALLER_WORKFLOW_FILE"
assert_workflow_not_contains \
"does not use the unavailable inputs context in a reusable workflow call" \
'${{ inputs.max_issues' \
"$CALLER_WORKFLOW_FILE"

echo "All CVE remediation tests passed."
2 changes: 1 addition & 1 deletion .github/workflows/cve-remediation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ jobs:
remediate:
uses: ./.github/workflows/_cve-remediation.yml
with:
max_issues: ${{ inputs.max_issues || 50 }}
max_issues: ${{ fromJSON(github.event.inputs.max_issues || '50') }}
secrets: inherit
Loading