fix: pass reusable workflow input from event - #1539
Merged
Merged
Conversation
Contributor
|
@brendan-kellam your pull request is missing a changelog! |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe caller workflow now converts ChangesCVE remediation issue-limit propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References SOU-1830.
GitHub only allows the github and needs contexts in a reusable-workflow job with block. Read the manual input through github.event.inputs and convert it with fromJSON so both workflow_dispatch and scheduled runs pass a number; scheduled runs retain the default of 50.
Validation:
Note
Low Risk
Workflow-only change to satisfy GitHub Actions context rules; behavior intent (default 50, optional manual limit) stays the same.
Overview
Fixes how Nightly CVE Remediation passes
max_issuesinto the reusable_cve-remediation.ymljob. GitHub only allowsgithubandneedsin auses:block, so the caller no longer references${{ inputs.max_issues }}.The caller now uses
${{ fromJSON(github.event.inputs.max_issues || '50') }}, so manual runs honor the workflow_dispatch input and scheduled runs still get the numeric default of 50.The CVE remediation regression script can assert against either workflow file and adds checks that the caller uses the allowed expression and does not reference the invalid
inputscontext.Reviewed by Cursor Bugbot for commit 25fc407. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit