Skip to content

2026 10 21 api sync - #16

Merged
burgaard merged 9 commits into
mainfrom
2026-10-21-api-sync
Oct 22, 2026
Merged

burgaard merged 9 commits into
mainfrom
2026-10-21-api-sync

Conversation

@burgaard

Copy link
Copy Markdown
Contributor

No description provided.

Kim Burgaard added 3 commits October 21, 2026 09:18
b62c912 Updated tools

git-subtree-dir: .claude/skills/seclai-sdk-sync
git-subtree-split: b62c912a31a9a89ae5e398ef193e7cf064a09895
Add content-attachment, accepted-attachment and email-source rejection
methods to Seclai and AsyncSeclai, regenerate the models, add the new
ApiVersion members and move LATEST_API_VERSION to 2026-10-19.
Comment thread README.md Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread README.md Resolved

@burgaard burgaard left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (medium) of c97b03a. No crash bugs found; 7 findings: 2 behavior inconsistencies, 3 cleanups, 2 doc errors. Six are inline below.

Behavior inconsistency (outside the diff): seclai/seclai.py:1214 (async twin ~5383, and run_streaming_agent)
run_streaming_agent_and_wait still calls response.read() on an error status with nothing around it. This PR added that protection to _stream_get but not here. If the stream endpoint returns 502 and the connection resets while the error body is read, the caller gets httpx.ReadError instead of SeclaiAPIStatusError(502), which is the case the CHANGELOG "Fixed" entry says no longer happens. The error type now depends on which method is called.

Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the latest commit (c97b03a..c0325df, medium effort). No correctness bugs found; the include_reasoning drop and the new streaming status-error handling behave as the CHANGELOG describes, and the targeted tests pass. Five minor notes inline.

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread tests/test_new_methods.py Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (medium) of the latest commit: no correctness bugs, 3 minor documentation notes.

Comment thread seclai/seclai.py Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread seclai/seclai.py Resolved
Comment thread seclai/seclai.py Resolved
Comment thread tests/test_new_methods.py Resolved
@burgaard
burgaard merged commit e512db4 into main Oct 22, 2026
1 check passed
@burgaard
burgaard deleted the 2026-10-21-api-sync branch October 22, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant