Repository navigation
Synchronized with the latest API changes - #18
Conversation
burgaard
left a comment
There was a problem hiding this comment.
Code review (high effort). No correctness bugs found: tests (1502 passed), mypy, ruff and black are clean, every new query param matches the spec's name and type, and sync and async are symmetric.
Two findings are on lines outside this diff:
-
seclai/seclai.py:3413-3414(async:8276-8277):set_accepted_attachments()docstring is stale. It still says "Onlydynamic_inputandemail_receivedtriggers take files". This spec'sSetAcceptedAttachmentsRequestnow listsslack_commandtoo, and the PR addsset_slack_trigger_config(). So someone setting up the new Slack trigger is told it can't take attachments. -
seclai/seclai.py:2291(async:7136):create_agent()docstring doesn't mention the new gallery fields. The newlist_agent_examples()docstring says to pass an entry'skeyasagent_templatetocreate_agentwithresource_bindings. Butcreate_agent'sbodydoc still says only "(name, description, etc.)". It doesn't mentionagent_template,resource_bindings,create_missing_resources, or thecreated_resources/solution_idit now returns.
|
On the review summary: Review 5721565186, body item 1 (
|
…19cd aea19cd Updated skills git-subtree-dir: .claude/skills/seclai-changelog git-subtree-split: aea19cd492abe95322e1066cee228c529b9e2db4
5b4e063 Updated skills 14a086e Addressed review comments 4a9410f Addressed review comments 683ba85 Addressed review comments f16043e Addressed review comments 9f5a04b More audit tool fixes 20f845d Addressed review comments 77cecda Updated the audit-tool git-subtree-dir: .claude/skills/seclai-sdk-sync git-subtree-split: 5b4e0631ddc4763967fcb2bf25c1623709a7e3dd
burgaard
left a comment
There was a problem hiding this comment.
Code review of HEAD~1..HEAD (a907cc7, the merge of the seclai-sdk-sync subtree squash 21affe9). That commit is not pushed yet: the PR head is 0977233 and neither changed file is in the PR diff, so the findings are listed here and not as inline comments.
-
.claude/skills/seclai-sdk-sync/sdksync.py:1235:_ts_wrapped_typeslicesOmit<…>/Partial<…>withbalanced_slice(…, "<", ">"), and that function counts the>of an arrow=>as a closing bracket.split_argswas fixed for this in the same change. Example:opts: Cfg<{ cb: () => void }>→opts: Partial<Cfg<{ cb: () => void }>>(or anyOmit<…>whose type has an arrow) gets cut at=>, the comparison fails, and a compatible change is reported as break, not warn. Fix: skip>when the previous character is=inbalanced_slicetoo, or share one bracket scanner. -
.claude/skills/seclai-sdk-sync/SKILL.md:326: The new text says#minormust be in a commit message "(not the PR title)". This repo squash-merges (for example e512db4 "2026 10 21 api sync (#16)"). The squash commit's subject is the PR title, andgithub-tag-actionreads that commit message. A#minorin the PR title therefore counts. The sentence above it also still says the version comes from "the merge commit message", so the note contradicts itself and may stop people from using the simplest place to put the bump. -
.claude/skills/seclai-sdk-sync/sdksync.py:342:split_argsnow handles=>, but every<still opens a level. Go's<-chan T(e.g.ch <-chan Event, opts *Opts) never closes it, so all later commas stay unsplit (split_args("ch <-chan int, x int")→ one entry).surface/paramsthen see the wrong arity and report a phantom "parameter list changed". Fix: ignore<when the next character is-. -
.claude/skills/seclai-sdk-sync/sdksync.py:1112:strip_comments(…, "#")runs over Python source that includes triple-quoted docstrings._quoted_endreads"""as an empty""plus a new quote, and literals only close on the same line. A#in a multi-line docstring is therefore treated as a comment:"""doc\n it is #1 "q\n"""becomesit is \n. Signatures are unaffected today. But the stripped text no longer matches the source, and any later scan of this text for strings (or adefinside a docstring) breaks silently. Handle"""/'''in_quoted_end. -
.claude/skills/seclai-sdk-sync/sdksync.py:1157:_ts_object_memberscallsstrip_comments(body)again. Its only input comes frompublic_surface, which has already stripped comments from the whole file (line 1112). That is a second full character-by-character pass over every options object on every compare. Drop it, or say the helper accepts raw text and stop stripping upstream. -
.claude/skills/seclai-sdk-sync/sdksync.py:423: Comment removal now has two implementations. The new string-awarestrip_commentsis used forsurface. The older regexstrip_docsis used forrequest_blocks/endpoint_helpers/helper_called, does not know about strings, and only removes whole-line comments.params/returnstherefore still see trailing// …comments and parens or apostrophes inside them, which is the failure this change fixes forsurface. Fix the root cause: runrequest_blocksand helper detection throughstrip_comments(withline_comment) as well, and retirestrip_docs. -
.claude/skills/seclai-sdk-sync/sdksync.py:1227: The same parameter-head regex ([\w$]+\s*\??\s*:\s*) appears in_ts_inline_object(1138) and_ts_wrapped_type(1227). The member regex appears in_ts_object_membersand again as_TS_MEMBER_RE. Whitespace normalisation is re-declared asnorm = lambda(1249) next to thenorminpublic_surfaceand several inline" ".join(x.split())calls. Move the shared regexes and one_normhelper to module level so they cannot drift apart. -
.claude/skills/seclai-sdk-sync/SKILL.md:145: The new WARN bullet packs four rules and their caveats into one sentence, with nested parentheses and semicolons ("never to an empty{}, which accepts any value the new type may reject; every other member unchanged…"). It is hard to tell which condition applies to which case. Split it into a sub-list with one line per compatible change: options-object member, widened toundefined,Omit,Partial.
…b9d6 0f1b9d6 Updated skills and guards git-subtree-dir: .claude/skills/seclai-changelog git-subtree-split: 0f1b9d67b07b47b69cab19d9ade3fe62687b53a2
f6aa6eb Updated skills and guards git-subtree-dir: .claude/skills/seclai-sdk-sync git-subtree-split: f6aa6ebc8a8457cb4b2535e41ee0d1258647d422
No description provided.