Skip to content

Make the publication test archives deterministic #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinjlacy merged 1 commit into from
Nov 12, 2026
Merged

Make the publication test archives deterministic #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tooling/extension-bindings/ci/test_publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ def make_assets(self):
prefix = binding.directory + "/" if suffix == ".source.zip" else binding.module + "@v" + binding.version + "/"
with zipfile.ZipFile(path, "w") as archive:
for source in sorted((self.root / binding.directory).iterdir()):
archive.writestr(prefix + source.name, source.read_bytes())
# A fixed timestamp keeps the archive identical on every build, like the
# orchestrator's deterministic zips. writestr(name, ...) would stamp the
# current time and fail the "existing release asset differs" check
# whenever two builds straddle a two second boundary.
entry = zipfile.ZipInfo(prefix + source.name, date_time=(1980, 1, 1, 0, 0, 0))
archive.writestr(entry, source.read_bytes())
else:
path.write_text("test resource\n")
manifest[path.name] = hashlib.sha256(path.read_bytes()).hexdigest()
Expand Down