Repository navigation
Make the publication test archives deterministic - #36
Merged
colinjlacy merged 1 commit intoNov 12, 2026
Merged
Conversation
make_assets built the test zips with ZipFile.writestr(name, data), which stamps each entry with the current time at two second resolution. The test test_unchanged_module_tag_is_reusable_after_unrelated_commits builds the assets twice around a commit, so when the builds fell into different two second windows the archives differed and promote failed with "existing release asset differs". The test failed at random, which failed the Test publication helpers step of the Publish Go bindings workflow, and the same test runs in Tests and Generate. Write the entries with a fixed timestamp, as the orchestrator's deterministic zips do. Forcing the two builds more than two seconds apart failed before this change and passes after it.
colinjlacy
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_assets built the test zips with ZipFile.writestr(name, data), which stamps each entry with the current time at two second resolution. The test test_unchanged_module_tag_is_reusable_after_unrelated_commits builds the assets twice around a commit, so when the builds fell into different two second windows the archives differed and promote failed with "existing release asset differs". The test failed at random, which failed the Test publication helpers step of the Publish Go bindings workflow, and the same test runs in Tests and Generate.
Write the entries with a fixed timestamp, as the orchestrator's deterministic zips do. Forcing the two builds more than two seconds apart failed before this change and passes after it.