Repository navigation
Conversation
Some weapons reuse another weapon's animations: Soldier's Concheror uses the Shovel's draw, idle and swings, Engineer's Widowmaker shares a wrench animation, and spellbooks share melee swings with the Persian Persuader and Solemn Vow. Hiding one of them hid the shared animations too, so "Keep melee visible" left Soldier with no visible Shovel. An animation is now hidden only when every weapon using it is hidden. Each class names hidden weapons that stay partly visible because of this. The catalog identity now includes the rule version, so packs built before this change read as outdated and their choices come back as an unbuilt draft to build again.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Some weapons reuse another weapon's animations in the class animation model. Soldier's Concheror uses the Shovel's draw, idle and swing animations; Engineer's Widowmaker shares an animation with the wrenches; spellbooks share swings with the Persian Persuader (Demoman) and Solemn Vow (Medic). Hiding one weapon hid those shared animations as well, so Keep melee visible left Soldier's Shovel invisible, and other classes lost some melee animations.
What changed
Checks
cargo fmt --check,cargo clippy -D warnings, new resolution tests inviewmodel_group_selection.pnpm check,pnpm test(new UI tests for the outdated-pack draft and the partly-visible line),tsc --noEmit.