Repository navigation
[mypyc] Add primitive for str.isidentifier - #22406
Merged
Merged
Conversation
ASCII strings are checked using a fast path. Other strings use PyUnicode_IsIdentifier. Part of mypyc/mypyc#644.
13 of 14 tasks
…ifier # Conflicts: # mypyc/doc/str_operations.rst # mypyc/lib-rt/CPy.h # mypyc/lib-rt/str_ops.c # mypyc/primitives/str_ops.py # mypyc/test-data/fixtures/ir.py # mypyc/test-data/irbuild-str.test # mypyc/test-data/run-strings.test
JukkaL
pushed a commit
that referenced
this pull request
Nov 12, 2026
Follow-up to the review comment in #22407. Tests for `chr()`, `str.lower()`/`str.upper()`, `str.isspace()`, `str.isdigit()` and the `str.is*` methods added in #22404 compared the result against the generic implementation for every code point (0 to 0x10FFFF), which is slow, especially through the generic code path. Now these tests check all code points in the BMP, which covers the 1-byte and 2-byte string kinds, and every 97th code point above it, plus the largest code point. This is about 76K code points instead of 1.1M. The same change is applied to the tests in #22405 and #22406.
Collaborator
|
This has a merge conflict now. |
…ifier # Conflicts: # mypyc/doc/str_operations.rst # mypyc/lib-rt/CPy.h # mypyc/lib-rt/str_ops.c # mypyc/primitives/str_ops.py # mypyc/test-data/fixtures/ir.py # mypyc/test-data/irbuild-str.test # mypyc/test-data/run-strings.test
Contributor
Author
|
Merged master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a primitive for
str.isidentifier().ASCII strings are checked using a fast path (
[A-Za-z_][A-Za-z0-9_]*). Other strings usePyUnicode_IsIdentifier.Tests compare the results against CPython for every code point, both in the start and the continuation position, and for a set of multi-character strings.
Micro-benchmark (2M iterations over 11 short strings, compiled code, generic method call through
Anyvs the new primitive, Python 3.13): 0.462s -> 0.145s.Part of mypyc/mypyc#644.