Skip to content

[mypyc] Add primitive for str.isidentifier - #22406

Merged
JukkaL merged 4 commits into
python:masterfrom
Jahongir-Qurbonov:mypyc-str-isidentifier
Nov 16, 2026
Merged

JukkaL merged 4 commits into
python:masterfrom
Jahongir-Qurbonov:mypyc-str-isidentifier

Conversation

@Jahongir-Qurbonov

Copy link
Copy Markdown
Contributor

Add a primitive for str.isidentifier().

ASCII strings are checked using a fast path ([A-Za-z_][A-Za-z0-9_]*). Other strings use PyUnicode_IsIdentifier.

Tests compare the results against CPython for every code point, both in the start and the continuation position, and for a set of multi-character strings.

Micro-benchmark (2M iterations over 11 short strings, compiled code, generic method call through Any vs the new primitive, Python 3.13): 0.462s -> 0.145s.

Part of mypyc/mypyc#644.

ASCII strings are checked using a fast path. Other strings use
PyUnicode_IsIdentifier.

Part of mypyc/mypyc#644.
@Jahongir-Qurbonov Jahongir-Qurbonov mentioned this pull request Nov 10, 2026
13 of 14 tasks
…ifier

# Conflicts:
#	mypyc/doc/str_operations.rst
#	mypyc/lib-rt/CPy.h
#	mypyc/lib-rt/str_ops.c
#	mypyc/primitives/str_ops.py
#	mypyc/test-data/fixtures/ir.py
#	mypyc/test-data/irbuild-str.test
#	mypyc/test-data/run-strings.test
JukkaL pushed a commit that referenced this pull request Nov 12, 2026
Follow-up to the review comment in #22407.

Tests for `chr()`, `str.lower()`/`str.upper()`, `str.isspace()`,
`str.isdigit()` and the `str.is*` methods added in #22404 compared the
result against the generic implementation for every code point (0 to
0x10FFFF), which is slow, especially through the generic code path.

Now these tests check all code points in the BMP, which covers the
1-byte and 2-byte string kinds, and every 97th code point above it, plus
the largest code point. This is about 76K code points instead of 1.1M.

The same change is applied to the tests in #22405 and #22406.
@JukkaL

JukkaL commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

This has a merge conflict now.

…ifier

# Conflicts:
#	mypyc/doc/str_operations.rst
#	mypyc/lib-rt/CPy.h
#	mypyc/lib-rt/str_ops.c
#	mypyc/primitives/str_ops.py
#	mypyc/test-data/fixtures/ir.py
#	mypyc/test-data/irbuild-str.test
#	mypyc/test-data/run-strings.test
@Jahongir-Qurbonov

Copy link
Copy Markdown
Contributor Author

Merged master.

@JukkaL JukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JukkaL
JukkaL merged commit d16ded7 into python:master Nov 16, 2026
19 checks passed
@Jahongir-Qurbonov
Jahongir-Qurbonov deleted the mypyc-str-isidentifier branch November 16, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants