Repository navigation
[mypyc] Only check a sample of non-BMP code points in str tests - #22448
Merged
Merged
Conversation
Tests for chr() and several str methods compared the result against the generic implementation for every code point, which is slow, especially when using the generic implementation. Check all code points in the BMP, which covers the 1-byte and 2-byte string kinds, and every 97th code point above it (and the largest one).
JukkaL
approved these changes
Nov 12, 2026
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for helping with test performance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review comment in #22407.
Tests for
chr(),str.lower()/str.upper(),str.isspace(),str.isdigit()and thestr.is*methods added in #22404 compared the result against the generic implementation for every code point (0 to 0x10FFFF), which is slow, especially through the generic code path.Now these tests check all code points in the BMP, which covers the 1-byte and 2-byte string kinds, and every 97th code point above it, plus the largest code point. This is about 76K code points instead of 1.1M.
The same change is applied to the tests in #22405 and #22406.