Repository navigation
Finish VisPy volume rendering and native teardown - #98
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 88.10% 88.86% +0.75%
==========================================
Files 64 64
Lines 3305 3349 +44
==========================================
+ Hits 2912 2976 +64
+ Misses 393 373 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@kephale thanks for the PR! Sorry I didn't respond sooner!
Thank you very much for doing this - these were a constant annoyance, but the activation energy was just a little too high for me to debug on a non-Windows system 😅 Unsure if you're still working on this - let me know if/when you'd like any review! |
|
@gselzer yeah i think this one is ready for review! |
|
Awesome, thank you @gselzer! I'm hoping to work through this early in the week |
|
thank you so much @kephale! Great to see you here... and would love to catch up soon. i'm interested in learning about lodstone, and looking into whether we could use/depend on it in ndv |
|
@gselzer this one could be worth checking in on when you get a chance! |
55c7587 to
66c4893
Compare
is_closed was removed in the recently released rendercanvas v3.0, and get_closed has been available since v2.5.1 (our lower bound)
Fixes #97.
This completes the SceneX VisPy path needed by Lodstone hosts:
scenex.show()The teardown changes eliminate the Linux exit-139 and macOS exit-138 crashes that occurred after all tests had passed.
Validation: