Repository navigation
Pin PyQt6 and wxPython in dev group to fix mypy lint - #101
Merged
Merged
Conversation
Collaborator
tlambert03
approved these changes
Nov 4, 2026
Member
|
@gselzer do you not use uv? If you do, then you get dev by default when you uv sync |
Collaborator
I do, but with particular project there are so many optional dependencies that I like to use more specificity - usually |
Member
feel free to remove those things from the dev group then, and provide more sane suggestion to devs in the readme! No need to have to work around a silly excess if it's not useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint on main has failed since mid-October because of two dependency releases:
QtGui.pyiwith invalid syntax (*args: T, /)), so mypy stops on parse errors._pygfx/_canvas.py,app/_wx.pyandtests/app/test_wx.py.This caps both in the
devgroup, which only the lint job installs. Test jobs use--no-devand still get the latest versions. Remove the caps once PyQt6 fixes its stubs and the wx code is updated for 4.3.2.The same change is in #98; landing this first lets that PR focus on the rendering changes.