Skip to content

Pin PyQt6 and wxPython in dev group to fix mypy lint - #101

Merged
gselzer merged 1 commit into
pyapp-kit:mainfrom
kephale:ci/pin-stub-breaking-deps
Nov 18, 2026
Merged

gselzer merged 1 commit into
pyapp-kit:mainfrom
kephale:ci/pin-stub-breaking-deps

Conversation

@kephale

@kephale kephale commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Lint on main has failed since mid-October because of two dependency releases:

  • PyQt6 6.12.0 ships QtGui.pyi with invalid syntax (*args: T, /)), so mypy stops on parse errors.
  • wxPython 4.3.2 ships new stubs that produce 13 mypy errors in _pygfx/_canvas.py, app/_wx.py and tests/app/test_wx.py.

This caps both in the dev group, which only the lint job installs. Test jobs use --no-dev and still get the latest versions. Remove the caps once PyQt6 fixes its stubs and the wx code is updated for 4.3.2.

The same change is in #98; landing this first lets that PR focus on the rendering changes.

@gselzer

gselzer commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Awesome, thanks @kephale! I'm fine with version caps in the dev group (which, if only linting uses, maybe should be renamed to lint or something?) - I never use the dev group personally 😅

You fixed the issue with that one failing build in #98, yeah?

@tlambert03

Copy link
Copy Markdown
Member

@gselzer do you not use uv? If you do, then you get dev by default when you uv sync

@gselzer

gselzer commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

@gselzer do you not use uv? If you do, then you get dev by default when you uv sync

I do, but with particular project there are so many optional dependencies that I like to use more specificity - usually uv sync --exact --no-dev --extra pygfx --extra pyqt6 or similar

@tlambert03

Copy link
Copy Markdown
Member

uv sync --exact --no-dev --extra pygfx --extra pyqt6

feel free to remove those things from the dev group then, and provide more sane suggestion to devs in the readme! No need to have to work around a silly excess if it's not useful

@gselzer
gselzer merged commit a161fac into pyapp-kit:main Nov 18, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants