Skip to content

Guard signature swap against uninitialized temp records #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Guard signature swap against uninitialized temp records #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a837a6
Initial plan
Copilot Sep 1, 2026
aadf9c3
fix: guard signature swap initialization
Copilot Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions BuildSignatures/PTEBuildSignatures.CodeUnit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ codeunit 80198 "PTE BuildSignatures"
AssemblyStyle: Option Gathering,Collecting,List;
AssemblyOrderUsed: List of [Integer];
FinishingSignatureCounter, FinishingSignaturesPerSheet : integer;
LastSignatureInitialized: Boolean;
begin

if in_SheetRec.ID = 0 then
Expand Down Expand Up @@ -211,8 +212,10 @@ codeunit 80198 "PTE BuildSignatures"
out_RecTmp.Modify(true);

// Special rule for residual sheet
if JobItemTMP."Entry No." = 1 then
LastSignatureTMP := out_RecTmp
if (JobItemTMP."Entry No." = 1) or (not LastSignatureInitialized) then begin
LastSignatureTMP := out_RecTmp;
LastSignatureInitialized := true;
end
else begin
// Switch values with last signature
out_RecTmp."Assembly Order" := LastSignatureTMP."Assembly Order";
Expand Down
7 changes: 5 additions & 2 deletions Planning Board - ToolTip Performance/PTETooltip.CodeUnit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ codeunit 80800 "PTE ToolTip"
AssemblyStyle: Option Gathering,Collecting,List;
AssemblyOrderUsed: List of [Integer];
FinishingSignatureCounter, FinishingSignaturesPerSheet : integer;
LastSignatureInitialized: Boolean;
begin

if in_SheetRec.ID = 0 then
Expand Down Expand Up @@ -264,8 +265,10 @@ codeunit 80800 "PTE ToolTip"
out_RecTmp.Modify(true);

// Special rule for residual sheet
if JobItemTMP."Entry No." = 1 then
LastSignatureTMP := out_RecTmp
if (JobItemTMP."Entry No." = 1) or (not LastSignatureInitialized) then begin
LastSignatureTMP := out_RecTmp;
LastSignatureInitialized := true;
end
else begin
// Switch values with last signature
out_RecTmp."Assembly Order" := LastSignatureTMP."Assembly Order";
Expand Down