Guard signature swap against uninitialized temp records - #93
Closed
PropmanProphecy with Copilot wants to merge 2 commits into
Closed
Guard signature swap against uninitialized temp records#93PropmanProphecy with Copilot wants to merge 2 commits into
PropmanProphecy with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: PropmanProphecy <8543071+PropmanProphecy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate failure of LastSignatureTMP.Modify in PrintVis app
Guard signature swap against uninitialized temp records
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastSignatureTMP.Modify()could run beforeLastSignatureTMPreferenced an inserted temporaryPVS Job Signaturesrow. This happens because the build order is cover-first, so the first processed item is not guaranteed to be the residual sheet ("Entry No." = 1).Root cause
LastSignatureTMPhad already been initialized.Build_Entriesimplementations, that assumption is false when a non-residual item is processed first.Change
LastSignatureTMPinstead of attempting aModify()on an uninitialized record.Scope
BuildSignatures/PTEBuildSignatures.CodeUnit.alPlanning Board - ToolTip Performance/PTETooltip.CodeUnit.alBehavioral effect
Original prompt
Created from VS Code.