Repository navigation
resource/pingone_davinci_flow: Add customTimeoutErrorScreen settings support - #152
Merged
Merged
Conversation
…support Bumps pingone-go-client to v0.13.0, which adds the four flow settings fields the SDK was previously missing (upstream: pingone-go-client#96, pingone-go-sdk-v2#543), and declares them in the flow definition: - custom_timeout_error_screen_css - custom_timeout_error_screen_html - custom_timeout_error_screen_message - use_custom_timeout_error_screen The SDK diff v0.12.0 -> v0.13.0 is purely additive (these four fields plus the User-Agent string), so no other definitions needed auditing. All four attributes are optional on the Terraform provider, so exports remain valid against the current provider. Fixes #144 Co-Authored-By: Claude Code <noreply@anthropic.com>
Regression Test Results
✅ No regressions detectedAll export configurations produced compatible output. Generated by regression workflow • View run |
This was referenced Sep 21, 2026
plambrechtsen
pushed a commit
to plambrechtsen/pingcli-plugin-terraformer
that referenced
this pull request
Sep 21, 2026
Adds TestDaVinciFlowTimeoutScreenSettings_ProcessorAndHCL, which drives the real flow.yaml definition with a v0.13.0 DaVinciFlowResponse carrying the four new settings fields through ProcessResource and the HCL formatter, proving they export as optional (non-skipped) attributes. Follow-up to pingidentity#152 / pingidentity#144. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
Summary
Bumps
pingone-go-clientto v0.13.0 and declares the newly available flow-settings fields in thepingone_davinci_flowdefinition:custom_timeout_error_screen_csscustom_timeout_error_screen_htmlcustom_timeout_error_screen_messageuse_custom_timeout_error_screenThe upstream SDK previously omitted these fields entirely (pingone-go-client#96 / pingone-go-sdk-v2#543), so exports silently dropped any flow settings that used the custom timeout error screen. v0.13.0 adds all four.
SDK bump audit
The v0.12.0 → v0.13.0 diff is purely additive: only the four new
DaVinciFlowSettingsResponsefields plus the User-Agent version string changed. No renames, no type changes — no other definitions required auditing (per the ARCHITECTURE.md bump rule).Tests
Validating tests: none added — the attributes are declared in YAML and exercised by the generic processor; there is no per-attribute Go code.
go run ./tools/validate-definitions definitions/passes (8/8), confirming the definitions parse and pass dependency analysis.Impacted tests passing:
go test ./... -count=1— all packages pass, exceptTestResolveEmbeddedReferences_DisambiguatedName_StableAcrossEnvironments, which is a pre-existing flaky test on main (map-iteration-order dependent; fails ~2/10 runs on unmodified main, verified viagit stash— documented in PR Prevent cross-type label suffixes from breaking references #146).go build ./...,go vet ./...— pass.Breaking changes
None. Purely additive attributes; SDK bump is drop-in.
Changelog
.changelog/pr-152.txtadded asrelease-note:enhancement.🤖 Generated with Claude Code