Skip to content

fix(fp): resolve dormant code and adopt lifecycle markers #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
netravnen wants to merge 1 commit into from
Draft

fix(fp): resolve dormant code and adopt lifecycle markers #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion user.js/peeringdb-fp-consolidated-tools.meta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ==UserScript==
// @name PeeringDB FP - Consolidated Tools
// @namespace https://www.peeringdb.com/
// @version 1.1.41
// @version 1.1.42
// @description Consolidated FP userscript for PeeringDB frontend (Net/Org/Fac/IX/Carrier)
// @author <chriztoffer@peeringdb.com>
// @match https://www.peeringdb.com/*
Expand Down
60 changes: 7 additions & 53 deletions user.js/peeringdb-fp-consolidated-tools.src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ==UserScript==
// @name PeeringDB FP - Consolidated Tools
// @namespace https://www.peeringdb.com/
// @version 1.1.41
// @version 1.1.42
// @description Consolidated FP userscript for PeeringDB frontend (Net/Org/Fac/IX/Carrier)
// @author <chriztoffer@peeringdb.com>
// @match https://www.peeringdb.com/*
Expand Down Expand Up @@ -95,9 +95,13 @@
// mechanism so re-verifying a row, or verifying a second row at the same
// exchange, doesn't re-fetch it.
const IXF_EXPORT_CACHE_TTL_MS = 15 * 60 * 1000;
// Legacy per-script cache key prefixes -- no longer written to; kept only
// so migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once.
// @deprecated — legacy per-script cache key prefixes, no longer written to; kept only so
// migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once; delete after the
// sweep has shipped long enough that no installs still hold pre-migration entries.
const LEGACY_API_PAYLOAD_CACHE_STORAGE_PREFIX = `${MODULE_PREFIX}.apiPayloadCache.`;
// @deprecated — legacy per-script cache key prefixes, no longer written to; kept only so
// migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once; delete after the
// sweep has shipped long enough that no installs still hold pre-migration entries.
const LEGACY_API_PAYLOAD_TAB_CACHE_STORAGE_PREFIX = `${MODULE_PREFIX}.apiPayloadTabCache.`;

/* @include admincom-entity-exclusions.js */
Expand Down Expand Up @@ -536,25 +540,6 @@
lastFetchFailureByUrl.delete(key);
}

/**
* Constructs HTTP headers for Tampermonkey requests with User-Agent.
* Purpose: Centralize header building for all script-initiated requests.
* Necessity: Ensures consistent User-Agent and other important headers across all API calls.
*/
function buildTampermonkeyRequestHeaders(baseHeaders = {}) {
const headers = { ...baseHeaders };
const userAgent = getCustomRequestUserAgent();

if (userAgent) {
headers["User-Agent"] = userAgent;
if (!headers["X-PDB-Request-UA"] && !headers["x-pdb-request-ua"]) {
headers["X-PDB-Request-UA"] = userAgent;
}
}

return headers;
}

/**
* Installs lightweight fetch instrumentation for debug diagnostics.
*/
Expand Down Expand Up @@ -2150,35 +2135,6 @@
host.style.display = row1.children.length || row2.children.length ? "flex" : "none";
}

/**
* Groups custom toolbar items by vertical pixel position (visual rows).
* Purpose: Detect which buttons wrap to new lines due to narrow viewports.
* Necessity: Understand natural wrapping behavior for spacing adjustments.
*/
function groupCustomItemsByVisualRow(customItems, topTolerance = 3) {
const rows = [];

customItems.forEach((item) => {
const top = item.offsetTop;
let row = rows.find((entry) => Math.abs(entry.top - top) <= topTolerance);

if (!row) {
row = { top, items: [] };
rows.push(row);
}

row.items.push(item);
row.top = Math.min(row.top, top);
});

rows.sort((a, b) => a.top - b.top);
rows.forEach((row) => {
row.items.sort((a, b) => a.offsetLeft - b.offsetLeft);
});

return rows;
}

/**
* Removes individual button margins to rely on container gap for spacing.
* Purpose: Standardize spacing through flexbox gap instead of element margins.
Expand Down Expand Up @@ -3768,7 +3724,6 @@
btn.addEventListener("click", () => {
void withActionLock("copy-user-roles", async () => {
const admins = [];
const members = [];

const currentUsers = qsa(
'#org-user-manager > div[data-edit-template="user-item"] > .editable'
Expand All @@ -3792,7 +3747,6 @@
?.getAttribute("data-edit-value");

if (role === "admin") admins.push(email);
if (role === "member") members.push(email);
});

// Legacy script only returned admins joined by newline
Expand Down
60 changes: 7 additions & 53 deletions user.js/peeringdb-fp-consolidated-tools.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ==UserScript==
// @name PeeringDB FP - Consolidated Tools
// @namespace https://www.peeringdb.com/
// @version 1.1.41
// @version 1.1.42
// @description Consolidated FP userscript for PeeringDB frontend (Net/Org/Fac/IX/Carrier)
// @author <chriztoffer@peeringdb.com>
// @match https://www.peeringdb.com/*
Expand Down Expand Up @@ -95,9 +95,13 @@
// mechanism so re-verifying a row, or verifying a second row at the same
// exchange, doesn't re-fetch it.
const IXF_EXPORT_CACHE_TTL_MS = 15 * 60 * 1000;
// Legacy per-script cache key prefixes -- no longer written to; kept only
// so migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once.
// @deprecated — legacy per-script cache key prefixes, no longer written to; kept only so
// migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once; delete after the
// sweep has shipped long enough that no installs still hold pre-migration entries.
const LEGACY_API_PAYLOAD_CACHE_STORAGE_PREFIX = `${MODULE_PREFIX}.apiPayloadCache.`;
// @deprecated — legacy per-script cache key prefixes, no longer written to; kept only so
// migrateLegacyApiPayloadCacheKeys() can sweep and remove old entries once; delete after the
// sweep has shipped long enough that no installs still hold pre-migration entries.
const LEGACY_API_PAYLOAD_TAB_CACHE_STORAGE_PREFIX = `${MODULE_PREFIX}.apiPayloadTabCache.`;

// >>> GENERATED by user.js/scripts/build_userscripts.py from peeringdb-fp-consolidated-tools.src.js + lib/admincom-entity-exclusions.js <<<
Expand Down Expand Up @@ -1032,25 +1036,6 @@
lastFetchFailureByUrl.delete(key);
}

/**
* Constructs HTTP headers for Tampermonkey requests with User-Agent.
* Purpose: Centralize header building for all script-initiated requests.
* Necessity: Ensures consistent User-Agent and other important headers across all API calls.
*/
function buildTampermonkeyRequestHeaders(baseHeaders = {}) {
const headers = { ...baseHeaders };
const userAgent = getCustomRequestUserAgent();

if (userAgent) {
headers["User-Agent"] = userAgent;
if (!headers["X-PDB-Request-UA"] && !headers["x-pdb-request-ua"]) {
headers["X-PDB-Request-UA"] = userAgent;
}
}

return headers;
}

/**
* Installs lightweight fetch instrumentation for debug diagnostics.
*/
Expand Down Expand Up @@ -2646,35 +2631,6 @@
host.style.display = row1.children.length || row2.children.length ? "flex" : "none";
}

/**
* Groups custom toolbar items by vertical pixel position (visual rows).
* Purpose: Detect which buttons wrap to new lines due to narrow viewports.
* Necessity: Understand natural wrapping behavior for spacing adjustments.
*/
function groupCustomItemsByVisualRow(customItems, topTolerance = 3) {
const rows = [];

customItems.forEach((item) => {
const top = item.offsetTop;
let row = rows.find((entry) => Math.abs(entry.top - top) <= topTolerance);

if (!row) {
row = { top, items: [] };
rows.push(row);
}

row.items.push(item);
row.top = Math.min(row.top, top);
});

rows.sort((a, b) => a.top - b.top);
rows.forEach((row) => {
row.items.sort((a, b) => a.offsetLeft - b.offsetLeft);
});

return rows;
}

/**
* Removes individual button margins to rely on container gap for spacing.
* Purpose: Standardize spacing through flexbox gap instead of element margins.
Expand Down Expand Up @@ -4264,7 +4220,6 @@
btn.addEventListener("click", () => {
void withActionLock("copy-user-roles", async () => {
const admins = [];
const members = [];

const currentUsers = qsa(
'#org-user-manager > div[data-edit-template="user-item"] > .editable'
Expand All @@ -4288,7 +4243,6 @@
?.getAttribute("data-edit-value");

if (role === "admin") admins.push(email);
if (role === "member") members.push(email);
});

// Legacy script only returned admins joined by newline
Expand Down
Loading