fix(fp): resolve dormant code and adopt lifecycle markers - #309
Draft
netravnen wants to merge 1 commit into
Draft
Conversation
netravnen
force-pushed
the
fix/fp-lifecycle-markers
branch
from
August 20, 2026 14:02
34b791d to
b19fc22
Compare
netravnen
force-pushed
the
fix/fp-lifecycle-markers
branch
2 times, most recently
from
August 20, 2026 20:01
2f2af53 to
813d181
Compare
netravnen
force-pushed
the
fix/fp-lifecycle-markers
branch
from
August 20, 2026 20:14
813d181 to
030484f
Compare
Applies what remains of the ratified fp triage now that the write-guard work has landed on dev-next. An earlier draft of this change staged FP's exclusion cluster as planned safety code with `@staged wip` markers; that cluster is now live upstream -- wired into the IX-F netixlan write paths and shared via lib/admincom-entity-exclusions.js -- and under the ratified @StaGeD grammar (markers only on unreferenced symbols) staging no longer applies, so those markers are dropped here rather than carried. What remains are the orphan deletions and the tree's first @deprecated adopters under the frozen grammar. Changes: - Delete groupCustomItemsByVisualRow (orphaned by the 7169919 toolbar refactor). - Delete the dead `members` array population in copy-user-roles; the admins-only clipboard output is byte-identical. - Delete FP's unused buildTampermonkeyRequestHeaders copy -- the identical body survives in CP and DP, and a hoped-for lib extraction is not a planned FP feature. - Convert LEGACY_API_PAYLOAD_CACHE_STORAGE_PREFIX and LEGACY_API_PAYLOAD_TAB_CACHE_STORAGE_PREFIX to the frozen `@deprecated — <reason; removal condition>` line-comment form, preserving the migrateLegacyApiPayloadCacheKeys() sweep prose. - Bump FP @Version to 1.1.42 (src + meta); regenerate .user.js. Testing: - Full suite green: 585 pass, 0 fail (1 pre-existing skip). - build --check and node --check on the regenerated .user.js: clean. - Verified by grep across all five source files + tests/ that zero references remain to groupCustomItemsByVisualRow, buildTampermonkeyRequestHeaders (FP copy) and the members array. Backwards Compatibility: - copy-user-roles output unchanged (admins joined by newline). - No live user-facing behavior changes; deleted code had no caller. Assisted-by: Claude:claude-opus-5 Assisted-by: Claude:claude-fable-5
netravnen
force-pushed
the
fix/fp-lifecycle-markers
branch
from
August 20, 2026 20:40
030484f to
5c03573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies what remains of the ratified fp triage now that the write-guard
work has landed on dev-next. An earlier draft of this change staged
FP's exclusion cluster as planned safety code with
@staged wipmarkers; that cluster is now live upstream -- wired into the IX-F
netixlan write paths and shared via lib/admincom-entity-exclusions.js
-- and under the ratified @StaGeD grammar (markers only on
unreferenced symbols) staging no longer applies, so those markers are
dropped here rather than carried. What remains are the orphan
deletions and the tree's first @deprecated adopters under the frozen
grammar.
Changes:
refactor).
membersarray population in copy-user-roles; theadmins-only clipboard output is byte-identical.
identical body survives in CP and DP, and a hoped-for lib extraction
is not a planned FP feature.
LEGACY_API_PAYLOAD_TAB_CACHE_STORAGE_PREFIX to the frozen
@deprecated — <reason; removal condition>line-comment form,preserving the migrateLegacyApiPayloadCacheKeys() sweep prose.
Testing:
references remain to groupCustomItemsByVisualRow,
buildTampermonkeyRequestHeaders (FP copy) and the members array.
Backwards Compatibility: