Skip to content

ci, build: use package.json for js deps - #56

Merged
ctron merged 1 commit into
patternfly-yew:mainfrom
isosphere:main
Aug 31, 2026
Merged

ctron merged 1 commit into
patternfly-yew:mainfrom
isosphere:main

Conversation

@isosphere

@isosphere isosphere commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

I understand that this project is currently using trunk's [[node_packages]] feature to install patternfly and fontawesome-free dependencies. However, this has drawbacks:

  • It requires hardcoded versions in index.html, style.scss, and in Trunk.toml
  • It doesn't work if the developer is using a shared target-dir with cargo via ~/.cargo/config.toml (like me)

This PR switches to using a package.json file and removes the hardcoded versions (aside from in the package.json).

Comment thread .github/workflows/ci.yaml Outdated


- name: npm install
run: npm install

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use npm ci?

@ctron
ctron merged commit 35d80a3 into patternfly-yew:main Aug 31, 2026
3 checks passed
@trust-git-bot

Copy link
Copy Markdown

🚀 Deployed Preview: https://patternfly-yew-quickstart-pr-56-preview.surge.sh ✨

@ctron ctron mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants