Repository navigation
ci, build: use package.json for js deps - #56
Merged
Merged
Conversation
ctron
reviewed
Aug 31, 2026
|
|
||
|
|
||
| - name: npm install | ||
| run: npm install |
|
🚀 Deployed Preview: https://patternfly-yew-quickstart-pr-56-preview.surge.sh ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand that this project is currently using trunk's
[[node_packages]]feature to install patternfly and fontawesome-free dependencies. However, this has drawbacks:index.html,style.scss, and inTrunk.tomltarget-dirwith cargo via~/.cargo/config.toml(like me)This PR switches to using a
package.jsonfile and removes the hardcoded versions (aside from in the package.json).