Repository navigation
Add new component examples - #57
Merged
Merged
Conversation
|
🚀 Deployed Preview: https://patternfly-yew-quickstart-pr-57-preview.surge.sh ✨ |
Member
|
I noticed the PR also changes back to Trunk's NPM client. There was a PR a while back which reverted this: #56 I personally like the embedded node client, but I can also understand the downsides. Maybe we can keep those changes out, and bring them back, once we resolved this downsides in Trunk? |
ctron
reviewed
Nov 17, 2026
| // $fa-font-path: "webfonts"; | ||
| @import "../node_modules/@fortawesome/fontawesome-free/scss/fontawesome"; | ||
| @import "../node_modules/@fortawesome/fontawesome-free/scss/brands"; | ||
| @import "../target/node_modules/@fortawesome/fontawesome-free/7.3.1/scss/fontawesome"; |
Member
There was a problem hiding this comment.
Could we drop the version part of the dependency? In trunk?
Contributor
Author
|
No problem to revert npm changes, I have submitted a PR on trunk to embed it in the package link, so dependent crates will not have to (re-)define npm dependencies. |
MarcAntoine-Arnaud
force-pushed
the
main
branch
from
November 17, 2026 13:59
d7c4e12 to
231a368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.