Skip to content

Add new component examples - #57

Merged
ctron merged 2 commits into
patternfly-yew:mainfrom
luminvent:main
Nov 17, 2026
Merged

ctron merged 2 commits into
patternfly-yew:mainfrom
luminvent:main

Conversation

@MarcAntoine-Arnaud

Copy link
Copy Markdown
Contributor

No description provided.

@trust-git-bot

Copy link
Copy Markdown

🚀 Deployed Preview: https://patternfly-yew-quickstart-pr-57-preview.surge.sh ✨

@ctron

ctron commented Nov 17, 2026

Copy link
Copy Markdown
Member

I noticed the PR also changes back to Trunk's NPM client. There was a PR a while back which reverted this: #56

I personally like the embedded node client, but I can also understand the downsides. Maybe we can keep those changes out, and bring them back, once we resolved this downsides in Trunk?

Comment thread assets/style.scss Outdated
// $fa-font-path: "webfonts";
@import "../node_modules/@fortawesome/fontawesome-free/scss/fontawesome";
@import "../node_modules/@fortawesome/fontawesome-free/scss/brands";
@import "../target/node_modules/@fortawesome/fontawesome-free/7.3.1/scss/fontawesome";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we drop the version part of the dependency? In trunk?

@MarcAntoine-Arnaud

Copy link
Copy Markdown
Contributor Author

No problem to revert npm changes, I have submitted a PR on trunk to embed it in the package link, so dependent crates will not have to (re-)define npm dependencies.

@ctron
ctron merged commit 39a0801 into patternfly-yew:main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants