Repository navigation
Pull OCI datasets with the docker config's credentials - #78
Merged
Merged
Conversation
`run`, `datasets download` and `datasets list` opened every registry anonymously, so a dataset in a private package failed with "not found, or not public" even after `docker login`, while `push` and `export` already read the same login. Store::open now takes the registry's credentials from the docker config as they do ($DOCKER_CONFIG/config.json, else ~/.docker/config.json: its credential helper, else its auths entry), and stays anonymous without any. An OCI layout reads no credentials. A registry with stale credentials in the config now refuses pulls of its public datasets instead of falling back to anonymous, as `docker pull` and `export` do. The anonymous error says to log in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
luiyen
approved these changes
Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run,datasets downloadanddatasets listpulled every OCI registry anonymously. A dataset in a private package failed withnot found, or not public (hbench pulls anonymously), even afterdocker login.pushandexportalready read that same login.Store::opennow takes the registry's credentials from the docker config, aspushandexportdo:$DOCKER_CONFIG/config.json, else~/.docker/config.json, using its credential helper, else itsauthsentry. Without credentials it stays anonymous, and an OCI layout reads no credentials.docs/REFERENCE.mdsays so, and the anonymous error now says to log in.Behaviour change: a registry with stale credentials in the config now refuses pulls of its public datasets, rather than falling back to anonymous.
docker pullandexportalready behave this way.Checks
cargo test: 424 passed, including a new test that a registry store takes the config's credentials and an OCI layout store never reads the config. Clippy (-D warnings) andcargo fmt --checkare clean.docker login,datasets downloadof a dataset in a private package fetched all 63 tasks. 0.3.11 refused the same command.DOCKER_CONFIGpointing at an empty dir, the same command fails with the new message.humanevalfix@1.0, still downloads.push_and_export_use_the_docker_config_credentialsnow also pulls throughStore::open_with_config. It needsHBENCH_TEST_OCI_AUTH_REGISTRY(aregistry:3with htpasswd), so it was skipped here and hasn't run.🤖 Generated with Claude Code