Skip to content

fix(files): open file actions menu with hotkey on non-Latin layouts #66112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(files): open file actions menu with hotkey on non-Latin layouts #66112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2feb76
fix(files): open file actions menu with hotkey on non-Latin layouts
lazerg Oct 31, 2026
1d7ef5c
fix(files): clarify action menu hotkey comment
lazerg Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/files/src/components/FileEntry/FileEntryActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,9 @@ export default defineComponent({
this.openedMenu = false
}

// a open the action menu
if (event.key === 'a' && !this.openedMenu) {
// Otherwise it's the `a` hotkey: open the action menu
// (matched by physical key, event.key may differ on non-Latin layouts, e.g. 'ф')
if (event.key !== 'Escape' && !this.openedMenu) {

@skjnldsv skjnldsv Nov 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, any keys will open the actions menu ? 🤔

@lazerg lazerg Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, onKeyDown is only called by the two useHotKey bindings (Escape and a), so anything that isn't Escape here is the a key. On a Russian layout event.key is "ф", which is why the old === 'a' check never passed.

@skjnldsv skjnldsv Nov 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the comment above it then ? :)

@lazerg lazerg Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment, thanks!

this.openedMenu = true
}
},
Expand Down