Repository navigation
Conversation
Assisted-by: Claude:claude-opus-5-5 Signed-off-by: lazerg <lazerg2@gmail.com>
lazerg
requested review from
kristian-zendato and
susnux
and removed request for
a team
October 31, 2026 08:08
skjnldsv
reviewed
Nov 1, 2026
|
|
||
| // a open the action menu | ||
| if (event.key === 'a' && !this.openedMenu) { | ||
| if (event.key !== 'Escape' && !this.openedMenu) { |
Member
There was a problem hiding this comment.
so, any keys will open the actions menu ? 🤔
Contributor
Author
There was a problem hiding this comment.
No, onKeyDown is only called by the two useHotKey bindings (Escape and a), so anything that isn't Escape here is the a key. On a Russian layout event.key is "ф", which is why the old === 'a' check never passed.
Member
There was a problem hiding this comment.
Could you update the comment above it then ? :)
Contributor
Author
There was a problem hiding this comment.
Updated the comment, thanks!
Signed-off-by: lazerg <lazerg2@gmail.com>
skjnldsv
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ahotkey for the file actions menu never fired on non-Latin layouts, because the handler re-checkedevent.key === 'a'afteruseHotKeyhad already matched the physical key. Now it only checks that the key is not Escape.AI (if applicable)