fix: report expired startup deadlines as timeouts

docs/testing.md

@@ -11,7 +11,7 @@ npm run test:image
 npm audit --audit-level=high
 ```
 
-`npm run check` covers strict TypeScript, 57 Action tests, 17 supervisor tests,
+`npm run check` covers strict TypeScript, 58 Action tests, 17 supervisor tests,
 and the bundled Action. Supervisor tests also run successfully under the image's
 Python 3.9 runtime.
 

src/orchestration.ts

@@ -12,7 +12,7 @@ import {
   type WorkflowIdentity,
 } from "./identity.js";
 import { encodeRunHookPayload } from "./payload.js";
-import { pollSequentially } from "./polling.js";
+import { PollingError, pollSequentially } from "./polling.js";
 import {
   getSafeErrorName,
   OperationRetryError,
@@ -349,6 +349,12 @@ function userFacingFailure(
       `${stage} exhausted Lambda MicroVM capacity in ${region}; review AWS Service Quotas for this account and Region`,
     );
   }
+  if (
+    (error instanceof PollingError && error.reason === "deadline") ||
+    (error instanceof OperationRetryError && error.reason === "deadline")
+  ) {
+    return new ActionExecutionError(`${stage} timed out in ${region}`);
+  }
   return new ActionExecutionError(
     `${stage} failed (${getSafeErrorName(error)})`,
   );

src/polling.ts

@@ -17,6 +17,8 @@ export type PollingOptions<TObserved, TResult> = {
 };
 
 export class PollingError extends Error {
+  public readonly reason: "deadline" | "terminal";
+
   public constructor(
     operation: string,
     reason: "deadline" | "terminal",
@@ -25,6 +27,7 @@ export class PollingError extends Error {
     const suffix = detail === undefined ? "" : ` (${detail})`;
     super(`${operation} polling failed: ${reason}${suffix}`);
     this.name = "PollingError";
+    this.reason = reason;
   }
 }
 
@@ -44,8 +47,10 @@ export async function pollSequentially<TObserved, TResult>(
     initialDelayMaxMs,
     baseIntervalMs,
     maxIntervalMs,
-    now,
   );
+  if (now() >= options.deadline) {
+    throw new PollingError(options.operation, "deadline");
+  }
 
   const initialDelay = Math.floor(
     assertRandom(random()) * (initialDelayMaxMs + 1),
@@ -101,12 +106,10 @@ function validateOptions(
   initialDelayMaxMs: number,
   baseIntervalMs: number,
   maxIntervalMs: number,
-  now: () => number,
 ): void {
   if (
     operation.trim().length === 0 ||
     !Number.isSafeInteger(deadline) ||
-    deadline <= now() ||
     !Number.isSafeInteger(initialDelayMaxMs) ||
     initialDelayMaxMs < 0 ||
     !Number.isSafeInteger(baseIntervalMs) ||

test/orchestration.test.ts

@@ -5,7 +5,6 @@ import { describe, expect, it, vi } from "vitest";
 import type { StartConfig, StopConfig } from "../src/config.js";
 import { decodeJitPayload } from "../src/payload.js";
 import {
-  ActionExecutionError,
   startRunner,
   stopRunner,
   type ActionReporter,
@@ -167,7 +166,7 @@ describe("Action orchestration", () => {
         createReporter().api,
         runtime.api,
       ),
-    ).rejects.toEqual(expect.any(ActionExecutionError));
+    ).rejects.toThrow("GitHub runner readiness timed out in us-east-1");
 
     expect(microvms.terminateRequests).toEqual(["mvm-1"]);
     expect(github.deleteRequests).toEqual([42]);

test/polling.test.ts

@@ -114,4 +114,16 @@ describe("quota-aware polling", () => {
       }),
     ).rejects.toThrow("deadline");
   });
+
+  it("classifies an already-expired deadline as a timeout", async () => {
+    await expect(
+      pollSequentially({
+        operation: "GetMicrovm",
+        deadline: 1_000,
+        observe: async () => "PENDING",
+        decide: () => ({ status: "pending" }),
+        now: () => 1_000,
+      }),
+    ).rejects.toThrow("polling failed: deadline");
+  });
 });