Skip to content

fix(cm): end the search-button hover colour chain in a literal fallback #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtskf merged 1 commit into from
Nov 9, 2026
Merged

fix(cm): end the search-button hover colour chain in a literal fallback #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions scripts/preview/vscode-theme-palettes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,10 @@
// editor-findMatchBackground, editor-findMatchHighlightBackground,
// editor-selectionHighlightBackground) are unstubbed for every themeKind today
// and stay that way. Each has a working var(--x, fallback) at its use site, with
// two chains worth knowing about:
// • button-hoverBackground — reached only through
// `var(--vscode-button-secondaryHoverBackground, var(--vscode-button-hoverBackground))`
// (cm/theme.ts, `.cm-panel.cm-search .cm-button:hover`): a two-level chain whose
// terminal arm is itself unstubbed with no literal behind it, so that hover
// surface renders unset HERE but not in a real host (registry hcDark =
// button.background). A genuine harness divergence — cosmetic, dev-only.
// one chain worth knowing about:
// • button-hoverBackground used to be a second chain without a literal terminal;
// it now ends in rgba(128, 128, 128, 0.3), so every unstubbed token has a
// working fallback.
// • toolbar-activeBackground — falls back to list-activeSelectionBackground
// (styles.css), which HC_DARK omits because the registry hcDark default is null,
// so it renders unset under hc-dark. But a real hc-dark host emits neither
Expand Down
2 changes: 1 addition & 1 deletion src/webview/cm/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ export const searchPanelThemeSpec = {
},
".cm-panel.cm-search .cm-button:hover": {
backgroundColor:
"var(--vscode-button-secondaryHoverBackground, var(--vscode-button-hoverBackground))",
"var(--vscode-button-secondaryHoverBackground, var(--vscode-button-hoverBackground, rgba(128, 128, 128, 0.3)))",
},
".cm-panel.cm-search label": {
fontSize: "var(--vscode-font-size)",
Expand Down
Loading