Repository navigation
fix(cm): end the search-button hover colour chain in a literal fallback - #485
Merged
Merged
Conversation
The chain var(--vscode-button-secondaryHoverBackground, var(--vscode-button-hoverBackground)) had no literal terminal, so a host emitting neither token painted no hover background. Also drop the now-obsolete exception note from the preview palette module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.cm-panel.cm-search .cm-button:hoverbackground chain ended in a variable with no literal behind it, so a host emitting neither token painted no hover surface. It now terminates inrgba(128, 128, 128, 0.3).Changes
src/webview/cm/theme.ts: add a literal terminal fallback to the hover chainscripts/preview/vscode-theme-palettes.mjs: update the exception note, since the chain now has a working fallbackRelated
--vscode-button-hoverBackgroundhas no terminal fallback at its only use siteTest Plan
pnpm test:unitgreen