Skip to content

fix #466, use loop to add current mineclonia signs - #468

Open
bgstack15 wants to merge 2 commits into
minetest-mapserver:masterfrom
bgstack15:dev/fix-signs-loop
Open

bgstack15 wants to merge 2 commits into
minetest-mapserver:masterfrom
bgstack15:dev/fix-signs-loop

Conversation

@bgstack15

Copy link
Copy Markdown
Contributor

I learned enough to use some loops, so it's not quite so repetitive like last time!

@bgstack15

Copy link
Copy Markdown
Contributor Author

I have added a patch that reads the newer "utext" field of Mineclonia signs.

@bgstack15 bgstack15 mentioned this pull request Sep 4, 2026
@BuckarooBanzay

Copy link
Copy Markdown
Member

sorry that i only get to this now: does this conflict with the changes to the mcl_signs list? 🤔

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Sep 15, 2026
@bgstack15

Copy link
Copy Markdown
Contributor Author

This was [accidentally] incorporated already with the merge of #473, so this could be closed. I had built off of this branch for that 473 work.
The node names are different than the legacy ones, which changed at some point in the past ~8 months. So to support legacy and newer mineclonia servers, I think all the names are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants