fix: expose desktop settings in console mode - #128
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Controller users cannot cancel shortcut capture or leave its editor without switching to keyboard or mouse.
Reviewed changes This review covers the console settings additions, shortcut editor and capture flow, tutorial overlay, and related documentation.
- Console settings parity Adds Playnite, Android TV, custom FPS, Steam restore behavior, tutorial, and data-folder controls using the shared settings model.
- Shortcut editing and overlays Reuses the desktop shortcut picker and adds console-specific controller capture, focus handling, and tutorial navigation.
- Guides and manual checks Documents the new settings and their manual verification.
GPT Luna | 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the incremental controller-capture update and its related manual test guidance.
- Controller cancellation Added lone B/Circle release as a capture-cancel action while preserving combinations that include B/Circle.
- Manual verification Updated the documented controller-only cancellation and editor-exit checks.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Console System tab exposed fixed shortcut suggestions and omitted several settings available in desktop mode. Users can now configure, change and clear custom controller shortcuts, select or clear the Playnite path, control Steam shutdown, configure Android TV, enter a custom FPS limit, replay the tutorial and open the data folder without switching interfaces.
The shortcut editor reuses capture and conflict validation from desktop Settings, suppresses global controller actions during capture, and restores focus to the selected shortcut. The tutorial has its own Console overlay; keyboard/controller navigation stays inside both panels and text fields retain caret navigation. Both interfaces use the same persisted settings.
Validation: 285 unit tests passed; Windows Release x64 build succeeded with zero errors and existing analyzer warnings; diff checks passed. Visible-app checks passed for opening the shortcut editor, entering/canceling capture with Escape, and completing all three Console tutorial steps. Physical controller capture and Android TV behavior remain documented manual checks in docs/TESTING.md.