fix: confirm window closing in the session switcher - #127
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Confirmation can leave the session switcher without a valid focus target when the app keeps the window open for a save prompt.
Reviewed changes The review covers the confirmation flow, localized strings, focus/input routing, and accompanying manual checks.
- Close confirmation Adds a modal confirmation for controller, keyboard, and per-card mouse close actions.
- Localized UI and manual checks Adds confirmation text in all supported locales and documents the expected cancellation, confirmation, and unsaved-document behavior.
GPT Luna | 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes The incremental review covers the focus restoration changes after confirming or cancelling a window close.
- Restore focus after confirmation Focuses the target card as the confirmation overlay closes, then moves focus to the surviving card or its neighbor after the close request completes.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closing a window from the session switcher previously sent the close request immediately. Mouse, controller and Delete now open a confirmation showing the target title, with Cancel focused initially. Cancel/B/Escape returns focus to the target; confirming sends the normal close request so application save prompts still work. Keyboard and controller navigation remain inside the modal.
Validation: 285 unit tests passed; Windows Release x64 build passed for the identical preview tree. Portuguese manual checks cover cancellation, confirmation and unsaved documents. Physical controller interaction remains a manual check.