Skip to content

fix: confirm window closing in the session switcher - #127

Merged
lippdev merged 3 commits into
mainfrom
fix/confirm-switcher-close
Sep 30, 2026
Merged

lippdev merged 3 commits into
mainfrom
fix/confirm-switcher-close

Conversation

@lippdev

@lippdev lippdev commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Closing a window from the session switcher previously sent the close request immediately. Mouse, controller and Delete now open a confirmation showing the target title, with Cancel focused initially. Cancel/B/Escape returns focus to the target; confirming sends the normal close request so application save prompts still work. Keyboard and controller navigation remain inside the modal.

Validation: 285 unit tests passed; Windows Release x64 build passed for the identical preview tree. Portuguese manual checks cover cancellation, confirmation and unsaved documents. Physical controller interaction remains a manual check.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Confirmation can leave the session switcher without a valid focus target when the app keeps the window open for a save prompt.

Reviewed changes The review covers the confirmation flow, localized strings, focus/input routing, and accompanying manual checks.

  • Close confirmation Adds a modal confirmation for controller, keyboard, and per-card mouse close actions.
  • Localized UI and manual checks Adds confirmation text in all supported locales and documents the expected cancellation, confirmation, and unsaved-document behavior.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using GPT Luna | 𝕏

Comment thread src/ConsoleMode/SessionMenuWindow.xaml.cs

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes The incremental review covers the focus restoration changes after confirming or cancelling a window close.

  • Restore focus after confirmation Focuses the target card as the confirmation overlay closes, then moves focus to the surviving card or its neighbor after the close request completes.

Pullfrog  | View workflow run | Using GPT Luna | 𝕏

@lippdev
lippdev merged commit 37235e8 into main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants