Skip to content

test: drop the type-ignore comments from two test files #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eomdahyeon merged 1 commit into from
Oct 4, 2026
Merged

test: drop the type-ignore comments from two test files #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/unit/core/test_list_all_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from kpubdata.exceptions import TransportError
from tests.unit.core.test_executor import (
FakeResponse,
FakeTransport,
_golden_spec,
_make_executor,
_ref,
Expand All @@ -27,10 +28,11 @@
_PAGE_SIZE = 500


class _LazyTransport:
class _LazyTransport(FakeTransport):
"""Builds each page when it is asked for, so the test holds no result itself."""

def __init__(self, pages: int, *, fail_on: int | None = None) -> None:
super().__init__()
self._pages = pages
self._fail_on = fail_on
self.requests = 0
Expand All @@ -55,7 +57,7 @@ def apt_spec() -> SpecDefinition:
def _peak_bytes(spec: SpecDefinition, pages: int) -> tuple[int, int]:
"""Peak traced memory while every batch is consumed and dropped, and the row count."""
transport = _LazyTransport(pages)
adapter = SpecDatasetAdapter("datago", [spec], _make_executor(transport)) # type: ignore[arg-type]
adapter = SpecDatasetAdapter("datago", [spec], _make_executor(transport))
gc.collect()
tracemalloc.start()
try:
Expand All @@ -81,7 +83,7 @@ def test_memory_follows_the_page_size_not_the_row_count(apt_spec: SpecDefinition
def test_a_failing_page_yields_nothing_and_raises(apt_spec: SpecDefinition) -> None:
"""Pages 1 and 2 were fetched; page 3 fails; no batch comes out (#789)."""
transport = _LazyTransport(5, fail_on=3)
adapter = SpecDatasetAdapter("datago", [apt_spec], _make_executor(transport)) # type: ignore[arg-type]
adapter = SpecDatasetAdapter("datago", [apt_spec], _make_executor(transport))
seen: list[int] = []

with pytest.raises(TransportError, match="boom"):
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_nodata_is_an_empty_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
extract_items,
)
from kpubdata.core.models import DatasetRef, Query
from kpubdata.core.representation import Representation
from kpubdata.core.spec import SpecDefinition, load_spec_file
from kpubdata.exceptions import ProviderResponseError
from kpubdata.providers.datago.envelope import DataGoEnvelopeParser
Expand All @@ -41,7 +42,7 @@ def _datago_ref(envelope_style: str | None) -> DatasetRef:
provider="datago",
dataset_key="sample",
name="sample",
representation="api_json", # type: ignore[arg-type]
representation=Representation.API_JSON,
operations=frozenset(),
raw_metadata=metadata,
)
Expand Down
Loading