test: drop the type-ignore comments from two test files - #803
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yeongseon
approved these changes
Oct 4, 2026
yeongseon
left a comment
Collaborator
There was a problem hiding this comment.
리뷰: diff 를 읽었고 걸리는 점이 없습니다. Representation.API_JSON 을 넘기고 _LazyTransport 를 FakeTransport 의 서브클래스로 만들어 ignore 없이 타입이 맞습니다. 테스트 동작은 바뀌지 않았고 CLEAN 입니다. 승인합니다.
남은 53곳을 이 PR 범위 밖으로 둔 것도 맞습니다 — 한 번에 치우려면 별도 이슈와 게이트(ratchet)가 먼저입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
#801 리뷰가 짚은 것과 같은 위반이 오늘 내가 이미 머지한 테스트에 세 곳 더 있다. AGENTS.md 는
type: ignore를 금지한다 ("Fix the type error instead of silencing it").tests/unit/test_nodata_is_an_empty_result.py(fix(core): treat NODATA (resultCode 03) as an empty result on every path #792):representation="api_json" # type: ignore[arg-type]tests/unit/core/test_list_all_memory.py(perf(core): keep one page in memory while list_all waits for the casting decision #802):_make_executor(transport) # type: ignore[arg-type]두 곳변경 내용
Representation.API_JSON을 넘긴다._LazyTransport를FakeTransport의 서브클래스로 만들어_make_executor가 받는 타입이 되게 했다.테스트 동작은 그대로다: 두 파일
13 passed. ruff 통과.범위
오늘 내가 추가한 파일만 고쳤다.
main의tests/에는type: ignore가 그 밖에도 53곳 남아 있다(git grep -c합계 56 중 이 3곳 제외) — 그것들은 건드리지 않았다.🤖 Generated with Claude Code