Repository navigation
Reject hidden Git index states and finish POSIX timeout cleanup - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
Audited current main after #69 (
9b886a2) and the production-readiness audit. Six new regression cases exposed five failures: hidden modifications under both Git index flags, missing sparse-checkout inputs, unresolved merge stages, and a surviving POSIX descendant after its timed-out parent exited.Changes
assume-unchanged/skip-worktreeentries before repository checks can run.--fail-on never, without writing a new report.No runtime dependencies, network access, telemetry, source uploads, automatic execution, evidence-status changes, or schema changes.
Validation
Local Linux / Node 24:
npm run lint(TypeScript typecheck): passed.npm test: 176 passed.npm run dogfood: all four checks passed; seven compiled targets observed; TypeScript source correctly remains partially verified.npm run demo: all four asserted scenarios passed.npm run test:action: passed, including production-only install and static-default checks.npm pack --dry-run: passed, including packaging lifecycle tests.git diff --check: passed.CI run 35710985411 passed all 12 applicable jobs: Linux/macOS/Windows × Node 22/24/26, generated-dist parity, PR dogfood, and source Action smoke. Every matrix job passed both tests and packaging. Linux/macOS run all 176 tests; Windows reports 167 passed and 9 expected platform skips, including the two new POSIX process-group tests. The published-release Action smoke is intentionally push-only and was skipped for this PR.
Remaining limitations
Sparse checkouts and even clean flagged entries are conservatively rejected: use a full checkout or clear the flags. Snapshot isolation and concurrent mutation protection are still absent. Submodule visibility and broader monorepo/runner support remain audit follow-ups. Process-group cleanup cannot contain deliberately detached descendants and is not an OS sandbox. Windows retains native tree termination.
Draft for review; do not merge automatically.