Repository navigation
Report submodule changes without borrowing nested verification evidence - #71
Merged
Merged
Conversation
hzw0813
marked this pull request as ready for review
September 22, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
Audited main after #70 (
72211d9) and the production-readiness audit. A committed submodule pointer update produced an empty-change report because all diffs ignored submodules. Python discovery could cross nested-repository boundaries, and immutable root checks could consume nested dirty/untracked inputs that the alignment gate never bound.Six new regression cases fail against the baseline distribution.
Changes
submodule: true, zero source-line counts, and no source hunks. Passing root checks, test-map declarations, and LCOV cannot verify nested contents.--run-checksselections containing indexed submodules before execution. Static immutable analysis and explicit working-tree execution remain available.No runtime dependencies, network calls, telemetry, uploads, LLM dependency, or automatic execution were added. No recursive submodule operations are introduced.
Validation
npm run dogfood: all four checks passed, seven compiled targets observed, source evidence correctly partial.npm run demo: all four asserted scenarios passed.npm run test:action: passed, including production-only install and static-default behavior.npm pack --dry-run: passed, including the repeated test/build lifecycle.git diff --checkpassed.Compatibility and remaining limitations
Submodules are not recursively analyzed. Content-only nested dirtiness is intentionally omitted from repository dirty status and disclosed in reports. Gitlink-to-file transitions remain conservative metadata-only assessments. Immutable execution is more restrictive until nested inputs can be snapshot-bound; explicitly enabled working-tree root commands may still execute nested code, but cannot verify gitlink changes.
Snapshot isolation, concurrent-mutation protection, broader monorepo/runner support, and unsupported module-resolution cases remain follow-ups. This is a focused correctness pass, not a claim of complete production readiness.
Draft for review; do not merge automatically.