Skip to content

fix(local): isolate workspace --name from Dory --dory-name - #90

Open
patrickleet wants to merge 1 commit into
feat/local-workbench-epicfrom
fix/workbench-preserve-shared-identity-ns
Open

fix(local): isolate workspace --name from Dory --dory-name#90
patrickleet wants to merge 1 commit into
feat/local-workbench-epicfrom
fix/workbench-preserve-shared-identity-ns

Conversation

@patrickleet

Copy link
Copy Markdown
Collaborator

Summary

  • Rename global Dory desktop flag to --dory-name so hops local up --name alice no longer rewrites kube/docker context
  • Reconcile stamps worktree namespace only on app workloads (Deployment/Service/Oidc/Features); shared Project/Role/Human keep chart namespaces
  • Unit tests for namespace policy dual isolation and clap flag separation

Stack

Stacked on feat/local-workbench-epic (#89).

Test plan

  • cargo test --bin hops-cli workspace_name_does_not_set_dory_name
  • cargo test --bin hops-cli ensure_namespace
  • Local dual-worktree suite against Dory (see distributed PR)

Preserve chart namespaces for shared identity MRs while stamping only
app workloads; rename the global Dory flag so dual workspaces cannot
rewrite the desktop kube/docker context.
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c35f27b-c622-478a-90ad-4e73c0168811

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Companion distributed suite PR: hops-ops/distributed#178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant