feat(local): dual providers, named clusters, workspace→cluster bind - #93
Open
patrickleet wants to merge 5 commits into
Open
feat(local): dual providers, named clusters, workspace→cluster bind#93patrickleet wants to merge 5 commits into
patrickleet wants to merge 5 commits into
Conversation
Wave B–D residual for local-workbench epic: - --cluster-provider/--cp and --docker-provider/--dp with --backend alias - providers.json persist; apply_docker_provider_env for dory sock - named kind clusters via --cluster-name (context kind-<name>) - workspace registry clusterName/kubeContext + sticky rebind policy - status/up surface cluster binding; unit tests for pure logic Stacked on feat/kind-hostpath-extramounts (PR #92).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…/open When --cluster-name is omitted, keep the workspace's bound cluster instead of comparing against the process default. Activate bound kube context before kubectl in status/down/open. Unit test covers sticky None request.
Mount $HOME/dev (or HOPS_KIND_EXTRA_MOUNT) instead of entire $HOME to avoid kube-proxy EMFILE on large Mac trees. After create, raise node inotify max_user_instances/watches so kind stays healthy with hostPath mounts. Live proof: hostPath UI on kind-hops Vite ready; host write visible in pod.
--rebind-cluster updates kubeContext even when cluster name is unchanged (stale dory → kind-hops). Keep $HOME/dev mount default + inotify sysctl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Residual epic apply for [[tasks/local-workbench-epic]] waves B–D (plus delivery selection proof):
--cluster-provider/--cp+--docker-provider/--dp(kind+dory preferred Mac hostPath)--backendstill maps 1:1--cluster-namefor named kind clusters (kind-<name>context)--rebind-clusterstatus/upshow cluster bindingStack
fix/workbench-preserve-shared-identity-nsfeat/kind-hostpath-extramountsfeat/lwb-cp-dp-providers(this)Test plan
cargo test providers/backend::kind/workbench::registry/ select_delivery$HOME(hostPath substrate from feat(local): kind extraMounts + Dory docker for hostPath spike #92)