Repository navigation
Call fcntl through a non-variadic wrapper - #634
Merged
Merged
Conversation
ccall cannot call a variadic C function portably. The only uses are F_GETFD and F_GETFL, which take no argument, so the wrapper takes none. Unlike capi (haskell#494), this keeps doctest working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kazu-yamamoto
added a commit
that referenced
this pull request
Nov 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #494.
fcntlis variadic, andccallcannot call a variadic C function portably (on aarch64-darwin, for instance, variadic arguments go on the stack). The only uses areF_GETFDandF_GETFLingetCloseOnExecandgetNonBlock, which take no third argument, so this addshsnet_fcntl_get(fd, cmd)toHsNet.h, following the otherhsnet_*wrappers, and calls it instead.#494 used
capi, which broke doctest; a plain C wrapper does not.Tested on macOS (GHC 9.12.4): 118 examples, 0 failures, and doctest runs as before.
🤖 Generated with Claude Code