Repository navigation
Conversation
The ccall calling convention doesn't support varargs functions, so switch to capi instead. See https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/ffi.html#varargs-not-supported-by-ccall-calling-convention
kazu-yamamoto
self-requested a review
January 13, 2021 00:22
kazu-yamamoto
requested changes
Jan 13, 2021
kazu-yamamoto
left a comment
kazu-yamamoto
left a comment
Collaborator
There was a problem hiding this comment.
Good catch.
May I ask you to add a comment like "varargs requires capi instead of ccall"?
Collaborator
|
It seems to me that |
Collaborator
|
@nrdmn do you have an interest in fixing this PR? |
kazu-yamamoto
added a commit
that referenced
this pull request
Nov 13, 2026
ccall cannot call a variadic C function portably. The only uses are F_GETFD and F_GETFL, which take no argument, so the wrapper takes none. Unlike capi (#494), this keeps doctest working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ccall calling convention doesn't support varargs functions, so
switch to capi instead. See
https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/ffi.html#varargs-not-supported-by-ccall-calling-convention
Related PR: haskellari/lukko#23