Skip to content

docs(bigquery): update load_table_dataframe code sample to use BigFrames #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shuoweil wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −18
Draft

docs(bigquery): update load_table_dataframe code sample to use BigFrames #18036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions packages/google-cloud-bigquery-storage/tests/unit/test_read_client_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import pytest
from google.api_core.gapic_v1 import client_info
from google.auth import credentials

from google.cloud.bigquery_storage_v1 import types

PROJECT = "my-project"
Expand Down Expand Up @@ -158,24 +157,15 @@ def test_read_rows(mock_transport, client_under_test):
["google.cloud.bigquery_storage_v1", "google.cloud.bigquery_storage_v1beta2"],
)
def test_init_default_client_info(module_under_test):
from google.api_core.gapic_v1.client_info import METRICS_METADATA_KEY

mut = importlib.import_module(module_under_test)

creds = mock.Mock(spec=credentials.Credentials)
client = mut.BigQueryWriteClient(credentials=creds)
expected_client_info = f"gccl/{mut.__version__}"

installed_version = mut.__version__
expected_client_info = f"gccl/{installed_version}"
with mock.patch("google.api_core.gapic_v1.method.wrap_method") as mock_wrap:
mut.BigQueryWriteClient(credentials=creds)

for wrapped_method in client.transport._wrapped_methods.values():
user_agent = next(
(
header_value
for header, header_value in wrapped_method._metadata
if header == METRICS_METADATA_KEY
),
None,
)
assert user_agent is not None
assert expected_client_info in user_agent
assert mock_wrap.call_count > 0
for call in mock_wrap.call_args_list:
client_info = call.kwargs.get("client_info")
assert client_info is not None
assert expected_client_info in client_info.to_user_agent()
Comment on lines +168 to +171

@gemini-code-assist gemini-code-assist Bot Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The local variable name client_info shadows the client_info module imported at the top of the file (line 20). To avoid confusion and improve code maintainability, rename the local variable to c_info.

Suggested change
for call in mock_wrap.call_args_list:
client_info = call.kwargs.get("client_info")
assert client_info is not None
assert expected_client_info in client_info.to_user_agent()
for call in mock_wrap.call_args_list:
c_info = call.kwargs.get("client_info")
assert c_info is not None
assert expected_client_info in c_info.to_user_agent()

Loading