docs(bigquery): update load_table_dataframe code sample to use BigFrames - #18036
Draft
shuoweil wants to merge 1 commit into
Draft
docs(bigquery): update load_table_dataframe code sample to use BigFrames#18036shuoweil wants to merge 1 commit into
shuoweil wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test_init_default_client_info unit test in test_read_client_v1.py to mock wrap_method and verify that the client info is correctly passed and formatted. Feedback was provided to rename the local variable client_info to avoid shadowing the imported module of the same name.
Comment on lines
+168
to
+171
| for call in mock_wrap.call_args_list: | ||
| client_info = call.kwargs.get("client_info") | ||
| assert client_info is not None | ||
| assert expected_client_info in client_info.to_user_agent() |
Contributor
There was a problem hiding this comment.
The local variable name client_info shadows the client_info module imported at the top of the file (line 20). To avoid confusion and improve code maintainability, rename the local variable to c_info.
Suggested change
| for call in mock_wrap.call_args_list: | |
| client_info = call.kwargs.get("client_info") | |
| assert client_info is not None | |
| assert expected_client_info in client_info.to_user_agent() | |
| for call in mock_wrap.call_args_list: | |
| c_info = call.kwargs.get("client_info") | |
| assert c_info is not None | |
| assert expected_client_info in c_info.to_user_agent() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
bigquery_load_table_dataframecode sample (which powerscloud.google.com/bigquery/docs/samples/bigquery-load-table-dataframe) to use BigQuery DataFrames (bigframes) instead of the legacyclient.load_table_from_dataframeAPI.Fixes #<522898394> 🦕