Skip to content

refactor: remove support for Drill - #1729

Merged
jeskepetr merged 1 commit into
masterfrom
PJE/F1-2434
Aug 11, 2026
Merged

refactor: remove support for Drill#1729
jeskepetr merged 1 commit into
masterfrom
PJE/F1-2434

Conversation

@jeskepetr

Copy link
Copy Markdown
Contributor

Summary

Removes DRILL from the data source type enums. Drill is being removed from the backend
(gdc-nas #25522), so the SDK no longer needs to model it. Mirrors the Greenplum removal in
#1723.

Unlike Greenplum there was never a hand-written CatalogDataSourceDrill class, so there is
nothing to drop from the gooddata_sdk exports, and no test or docs example to remove — this
change is narrower than #1723 by exactly those pieces.

  • drop the DRILL enum entry from the two source schemas it originates from,
    gooddata-metadata-client.json (5) and gooddata-scan-client.json (1), and from the merged
    gooddata-api-client.json (6)
  • drop it from the six generated models that mirror them — one line each, exactly the shape
    regeneration produces (the same 6/5/1 shape refactor: remove support for Greenplum #1723 produced)
  • reword two prose mentions of Drill as a multi-schema data source manager to Dremio only

Test Plan

  • all three schemas still parse as JSON; all six generated models still compile
  • pre-commit passed (ruff, ruff format, copyright, trailing whitespace, EOF)
  • ENABLE_DRILL_TO_URL_BY_DEFAULT is a drill-to-URL setting, unrelated to Apache Drill —
    left untouched, still 25 occurrences

The merged schemas/gooddata-api-client.json was edited line-wise rather than rebuilt through
the Makefile's jq -S -s step: jq 1.6 does not preserve number literals and rewrites unrelated
values (2.6E+92600000000, 1.01) across the file, while the checked-in copy was
produced with jq 1.7+. Same approach as #1723.

Risk

low — removes one value from generated enums plus schema definitions. No hand-written class
or export changes, so unlike #1723 there is no import-time breakage for anyone.

JIRA: https://gooddata.atlassian.net/browse/F1-2434

🤖 Generated with Claude Code

Drill is being removed from the backend (F1-2434), so the SDK no longer needs to model it.

Unlike Greenplum there was never a hand-written `CatalogDataSourceDrill` class, so there is
nothing to drop from `gooddata_sdk` exports and no test or docs example to remove. Two prose
mentions of Drill as a multi-schema data source manager are reworded to Dremio only.

The generated client was updated the supported way in spirit rather than by hand-rolling a new
shape: the `DRILL` enum entry was removed from the two source schemas it originates from --
gooddata-metadata-client.json and gooddata-scan-client.json -- and from the six generated
models that mirror them, which is exactly the six-file, one-line-each shape regeneration
produces (the same shape the Greenplum removal produced).

The merged schemas/gooddata-api-client.json was edited line-wise instead of being rebuilt
through the Makefile's `jq -S -s` step. jq 1.6 does not preserve number literals and rewrote
unrelated values (2.6E+9 -> 2600000000, 1.0 -> 1) across the file; the checked-in copy was
produced with jq 1.7+, which does.

`ENABLE_DRILL_TO_URL_BY_DEFAULT` is a drill-to-URL setting, unrelated to Apache Drill, and is
left untouched.

JIRA: F1-2434
risk: low
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 35 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eee18681-883f-49b6-b950-b347bc8372df

📥 Commits

Reviewing files that changed from the base of the PR and between a1ccba8 and 504b44d.

📒 Files selected for processing (11)
  • docs/content/en/latest/data/data-source/scan_schemata.md
  • gooddata-api-client/gooddata_api_client/model/declarative_data_source.py
  • gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py
  • gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py
  • gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py
  • gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py
  • gooddata-api-client/gooddata_api_client/model/test_definition_request.py
  • packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/service.py
  • schemas/gooddata-api-client.json
  • schemas/gooddata-metadata-client.json
  • schemas/gooddata-scan-client.json

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.15%. Comparing base (a1ccba8) to head (504b44d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1729   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files         271      271           
  Lines       18794    18794           
=======================================
  Hits        14876    14876           
  Misses       3918     3918           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeskepetr
jeskepetr merged commit 9103989 into master Aug 11, 2026
15 checks passed
@jeskepetr
jeskepetr deleted the PJE/F1-2434 branch August 11, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants