refactor: remove support for Drill - #1728
Conversation
Drill is being removed from the backend (F1-2434), so the SDK no longer needs to model it. Unlike Greenplum there was never a hand-written `CatalogDataSourceDrill` class, so there is nothing to drop from `gooddata_sdk` exports and no test or docs example to remove. Two prose mentions of Drill as a multi-schema data source manager are reworded to Dremio only. The generated client was updated the supported way in spirit rather than by hand-rolling a new shape: the `DRILL` enum entry was removed from the two source schemas it originates from -- gooddata-metadata-client.json and gooddata-scan-client.json -- and from the six generated models that mirror them, which is exactly the six-file, one-line-each shape regeneration produces (the same shape the Greenplum removal produced). The merged schemas/gooddata-api-client.json was edited line-wise instead of being rebuilt through the Makefile's `jq -S -s` step. jq 1.6 does not preserve number literals and rewrote unrelated values (2.6E+9 -> 2600000000, 1.0 -> 1) across the file; the checked-in copy was produced with jq 1.7+, which does. `ENABLE_DRILL_TO_URL_BY_DEFAULT` is a drill-to-URL setting, unrelated to Apache Drill, and is left untouched. JIRA: F1-2434 risk: low
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
+ Coverage 78.58% 79.15% +0.56%
==========================================
Files 271 271
Lines 18765 18794 +29
==========================================
+ Hits 14747 14876 +129
+ Misses 4018 3918 -100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Superseded by #1729, which is opened from a branch in this repository rather than my fork. |
Summary
Removes
DRILLfrom the data source type enums. Drill is being removed from the backend(gdc-nas #25522), so the SDK no longer needs to model it. Mirrors the Greenplum removal in
#1723.
Unlike Greenplum there was never a hand-written
CatalogDataSourceDrillclass, so there isnothing to drop from the
gooddata_sdkexports, and no test or docs example to remove — thischange is narrower than #1723 by exactly those pieces.
DRILLenum entry from the two source schemas it originates from,gooddata-metadata-client.json(5) andgooddata-scan-client.json(1), and from the mergedgooddata-api-client.json(6)regeneration produces (the same 6/5/1 shape refactor: remove support for Greenplum #1723 produced)
Test Plan
ENABLE_DRILL_TO_URL_BY_DEFAULTis a drill-to-URL setting, unrelated to Apache Drill —left untouched, still 25 occurrences
The merged
schemas/gooddata-api-client.jsonwas edited line-wise rather than rebuilt throughthe Makefile's
jq -S -sstep: jq 1.6 does not preserve number literals and rewrites unrelatedvalues (
2.6E+9→2600000000,1.0→1) across the file, while the checked-in copy wasproduced with jq 1.7+. Same approach as #1723.
Risk
low — removes one value from generated enums plus schema definitions. No hand-written class
or export changes, so unlike #1723 there is no import-time breakage for anyone.
JIRA: https://gooddata.atlassian.net/browse/F1-2434
🤖 Generated with Claude Code