pdfkit: UTF-16BE text strings so accented titles are not mojibake - #24
Merged
Conversation
/Title, /Author and bookmark /Title were written as byte strings, so a non-ASCII title — an accented section heading, a French document title — displayed as mojibake in a viewer. Add pdfTextString: pure-ASCII text stays a literal (…) string; text with any non-ASCII rune is written UTF-16BE with a leading BOM as a hex <FEFF…> string (astral characters as surrogate pairs). Use it for the document Title/Author and every outline item title. Tests cover the ASCII, accented (café), and astral (an emoji surrogate pair) encodings and that a document's accented metadata/bookmark is UTF-16BE, not raw UTF-8; 100% coverage, go vet and gofmt clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/Title,/Authorand bookmark/Titlewere written as byte strings, so a non-ASCII title — an accented section heading, a French document title — displayed as mojibake in a viewer.Add
pdfTextString: pure-ASCII stays a literal(…)string; text with any non-ASCII rune is written UTF-16BE with a BOM as a hex<FEFF…>string (astral characters as surrogate pairs). Used for the documentTitle/Authorand every outline item title.Tests cover the ASCII, accented (
café), and astral (an emoji surrogate pair) encodings, and that a document's accented metadata/bookmark is UTF-16BE not raw UTF-8. 100% coverage,go vet,gofmtclean.Makes bookmarks and metadata correct for accented (e.g. French) titles — the follow-up flagged when the outline landed.
🤖 Generated with Claude Code