engine: take go-pdfkit v0.10.0 so accented bookmark titles are correct - #207
Merged
Conversation
go-pdfkit v0.10.0 writes a non-ASCII PDF text string (/Title, /Author, outline
/Title) as UTF-16BE, so an accented section heading — \section{Résumé} — shows
correctly in a viewer's bookmark sidebar instead of as mojibake. The engine already
passes the UTF-8 title through AddOutlineItem; this bump makes the encoding right.
Bumps go-pdfkit v0.9.0 -> v0.10.0. Verified: a \section{Résumé} document renders a
PDF whose outline title is UTF-16BE (<FEFF…>), not the raw UTF-8 bytes; full engine
suite green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-pdfkit v0.10.0 (go-pdfkit/pdfkit#24) writes a non-ASCII PDF text string (
/Title,/Author, outline/Title) as UTF-16BE, so an accented section heading —\section{Résumé}— shows correctly in a viewer's bookmark sidebar instead of as mojibake. The engine already passes the UTF-8 title throughAddOutlineItem; this bump makes the encoding right.Bumps go-pdfkit v0.9.0 → v0.10.0. Verified: a
\section{Résumé}document renders a PDF whose outline title is UTF-16BE (<FEFF…>), not the raw UTF-8 bytes. Full engine suite,go vet,gofmtgreen.Completes the PDF bookmark feature for accented (e.g. French) documents.
🤖 Generated with Claude Code