Skip to content

feat!: drop wake panel, verdicts stub and dead leftovers (gitmoot/gitmoot#2593) - #141

Merged
jerryfane merged 1 commit into
mainfrom
intern/2593-dead-views-a
Nov 13, 2026
Merged

jerryfane merged 1 commit into
mainfrom
intern/2593-dead-views-a

Conversation

@jerryfane

Copy link
Copy Markdown
Collaborator

Part A of gitmoot/gitmoot#2593 (epic gitmoot/gitmoot#2578; assignment owner 2026-11-13, seat gitmoot-intern).

  • Remove WakeDataSource and /api/wakes, /api/wakes/summary, /api/wakes/receipts + Overview wake panel/tile.
  • Remove DataSource.BinaryVerdicts and /api/run/{id}/verdicts.
  • Remove SynthItems/Candidates from Attention (always empty), groom-proposal rank/text, Tasks Implementing column and planned/implementing ranks, Runs Kind facet.
  • Charts: drop the stale "codex & kimi … claude only" footer; colour map adds omp, keeps codex/claude/kimi/shell for history.
  • fakefeed: drop wake/verdict/synth/candidate fixtures and groom/memory/pipeline/orchestrate samples.
  • Unknown /api/ paths now 404 instead of serving the SPA shell, so removed routes 404.

Kept: Galaxy, /api/job/{id}/checks, Runs/state/Learning (part B).

Verification: go build/vet/test ./... pass. Live smoke against gitmoot built with this module (throwaway home): 16 pages 200, 25 API/asset routes 200, 3 event streams 200, wake + verdict routes 404. test-check prove: TestRemovedAPIRoutesNotFound, TestFakeTasksContractOrderingAndDeterminism, TestHandleAttention proven.

gitmoot side: a gitmoot/gitmoot PR bumps the pin to this commit.

…moot#2593)

Part A of gitmoot/gitmoot#2593 (dashboard dead views, keep Galaxy).

Removed from the DataSource contract and UI:
- Wake ledger: GET /api/wakes, /api/wakes/summary, /api/wakes/receipts,
  WakeDataSource and its types, the Overview "Wake obligations" panel and
  the "wake obligations" Today tile. gitmoot never implemented it; the panel
  always said "requires a newer gitmoot build". /api/stale-notifications
  covers the need.
- GET /api/run/{id}/verdicts, DataSource.BinaryVerdicts and the
  BinaryVerdict(s) types (SkillOpt, gone since #1752; the UI never called it).
- Attention.SynthItems / Attention.Candidates and their types and UI
  sections (always empty since #1752).
- The groom_proposal Needs-you rank and "groom proposals" text.
- The Tasks "Implementing" column and the planned/implementing ranks.
- The Runs column's static orchestrate/goal/implement Kind facet.
- The Charts "codex & kimi ... claude only" footnote; the runtime colour map
  gains omp (codex/claude/kimi stay for historical jobs).

Unknown /api/ paths now answer 404 instead of the 200 SPA shell, so removed
endpoints fail loudly. fakefeed drops the wake, verdict, synth and candidate
fixtures and the groom/memory/pipeline/orchestration sample text.

BREAKING CHANGE: DataSource no longer has BinaryVerdicts; Attention no longer
has SynthItems/Candidates; WakeDataSource and the wake/verdict types are gone.
@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e79d9862fd72c7-1

Decision: approved
Summary: Reviewed the full seven-file diff at cd13815 against base df87a23. No correctness or introduced design findings. Removed contracts have no remaining callers; removed and unknown API routes return non-HTML 404s, while page routes retain SPA fallback. Desktop/mobile checks confirmed the reduced Tasks board, gates-only Attention with working job checks, Runs without the Kind facet, updated Charts, and functioning Galaxy and Learning views. Build, vet, and tests passed locally. The frozen prior-verdict file contains no reviews for PR #141. No repository files changed.

Tests Run

  • /usr/local/go/bin/go version -> go1.26.4 linux/amd64
  • /usr/local/go/bin/go build ./... -> success
  • /usr/local/go/bin/go vet ./... -> success
  • /usr/local/go/bin/go test ./... -> success; dashboard package passed, developer command has no test files
  • /usr/local/go/bin/go test -count=1 -v -run "Test(RemovedAPIRoutesNotFound|ServeSPAFallback|FakeOverviewContractOrderingAndDeterminism|FakeTasksContractOrderingAndDeterminism|HandleAttention.|HandleJobChecks.|HandleRuns|HandleState.|HandleLearningSkills.|FakeGalaxyAgentRecordCoverage|Events.*)$" . -> success; all 17 selected tests passed
  • /usr/local/go/bin/go run ./cmd/gitmoot-dashboard-dev -addr 127.0.0.1:8099 + Python urllib.request HTTP assertions -> success; seven removed/unknown API paths returned 404, seven page routes returned HTML 200, two assets returned 200, and eight retained APIs returned valid JSON 200
  • Chromium browser smoke against the local developer server -> success; visually verified Overview without wakes, Tasks columns and card lifecycle, mobile default PR-open and Blocked-tab interaction, gates-only Attention and expanded failed job checks, Charts legend/text, Runs Status/Agent/Repo facets, populated Galaxy (15 nodes/32 links), and Learning Skills. No page errors recorded.

Raw runtime output was retained in local Gitmoot state and is not posted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant