Skip to content

feat!: drop single-run graph, Runs column, SSE, Learning page and template history (gitmoot/gitmoot#2593) - #142

Merged
jerryfane merged 2 commits into
mainfrom
intern/2593-dead-views-b
Nov 14, 2026
Merged

jerryfane merged 2 commits into
mainfrom
intern/2593-dead-views-b

Conversation

@jerryfane

Copy link
Copy Markdown
Collaborator

Part of gitmoot/gitmoot#2593 (part B; part A was #141). Epic gitmoot/gitmoot#2578 (assignment: owner 2026-11-13, seat gitmoot-intern).

Removed

  • Routes: /api/runs, /api/state, /events SSE (sse.go + test), /api/learning/skills. The static handler now 404s /events instead of serving the page shell (test covers all four).
  • DataSource methods Runs, State, Subscribe, Skills and their types (State, RunSummary, Skill*, TemplateVersionInfo, AgentTemplateInfo, HealthLock, ErrRunNotFound).
  • Fields: AgentDetail.Template/Versions, AgentConfigInfo.MaxBackground/IdleTimeout/Template, ConfigAgent.MaxBackground, AgentSummary.Ephemeral, Health.Locks; the recycle_overdue org feed kind (carry-over).
  • UI: single-run graph canvas and Runs column, Learning page, Workflows' "view as graph" link, template/version cards (Agents, Galaxy), the ephemeral-workers row, branch-lock rows. Old /?run= and /learning URLs redirect to /.
  • fakefeed.go trimmed; README route table rewritten.

Matching server-side removals: gitmoot #2588 (Orchestra), #2589 (templates), #2590 (worker sessions), #2591 (branch locks) and the #2593 part B server PR.

Kept

Overview, Tasks, Workflows, Jobs, Agents, Org (incl. escalations and overdue badges the server still sends), Comms, Fleet activity, Stale notifications, Attention gates, Health (runtime-session resource locks), Config, Charts, Galaxy (/api/graph), /api/events. /api/job/{id}/checks stays: result_check_failures has 323 rows, newest 2026-11-11.

Verification

  • gofmt, go build ./..., go vet ./..., go test -count=1 ./...: pass. The index.html script block passes node --check; every method it calls exists.
  • Browser proof with the gitmoot server branch built against this commit (dev-only replace), on a throwaway home made from a .backup of the live DB: all 13 kept pages loaded with every local request 200 and 0 page errors; /api/runs, /api/state, /events, /api/learning/skills return 404; no kept page requests a removed route. Screenshots and raw network log: /root/fleet-tools/state/gitmoot-scope-reduction/intern/dash-2593b/ (README.md has the table).

Merge order

This PR first; then the gitmoot server PR bumps the module pin (it no longer implements Runs/State/Subscribe/Skills, so it only builds against this commit).

…plate history (gitmoot/gitmoot#2593)

Removes /api/runs, /api/state, /events (sse.go), /api/learning/skills, the
Runs()/State()/Subscribe()/Skills() DataSource methods and their types,
AgentDetail.Template/Versions, AgentConfigInfo.MaxBackground/IdleTimeout/
Template, ConfigAgent.MaxBackground, AgentSummary.Ephemeral, Health.Locks
(HealthLock) and the recycle_overdue org feed kind. The UI loses the graph
canvas, Runs column, Learning page, template/version cards, the ephemeral
fleet row and branch-lock rows; fakefeed is trimmed to match. /api/job/{id}/checks
is kept (result_check_failures has 323 rows, newest 2026-11-11).
@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e7cd654724b377-1

Decision: approved
Summary: Reviewed the full diff from 7ac9a8d to c4573a5. No blocking correctness findings; one P3 leftover consumer of a removed field. Build, vet, tests, API assertions, and browser smoke checks passed. Thirteen retained pages returned 200; browser requests did not call retired endpoints; legacy URLs normalized to /. No prior PR #142 findings were present in the frozen verdict file or GitHub review/comment history. Runtime verification used FakeDataSource: matching-server integration proof could not be reproduced because the supplied /root/fleet-tools/.../README.md path was permission-denied.

Findings

  • Remove the Config table's retired Max bg column (P3)
    • body: ConfigAgent.MaxBackground is removed in datasource.go:573-579, but the retained Config renderer still reads a.max_background at line 5449 and emits the Max bg header at line 5451. With the new API contract, every row now displays '-'. This leaves a dead control-surface concept visible after its removal. Simpler shape: delete that cell and its header rather than retaining a placeholder for a field that can no longer arrive.
    • evidence: Executed GET /api/config confirmed max_background is absent from every agent. Browser inspection of /config showed headers [Agent, Runtime, Capabilities, Policy, Max bg, Model] and four '-' Max bg cells. Screenshot: /tmp/omp-sshots-15cd5bca5dc1d603.webp.
    • file: web/dist/index.html
    • line: 5449

Tests Run

  • export PATH=/usr/local/go/bin:$PATH; go version -> go1.26.4 linux/amd64.
  • go build ./... -> success.
  • go vet ./... -> success.
  • go test -v ./... -> PASS, including TestRemovedRoutesNotFound, TestHandleChangeEvents*, agent/config/health tests, Galaxy fixture coverage, and job-check tests.
  • go run ./cmd/gitmoot-dashboard-dev -> started successfully on :8099; stopped after review.
  • node <<'JS' (inline HTTP assertions against http://127.0.0.1:8099) -> 16 retained JSON endpoints returned 200; six retired endpoint/query variants returned 404; /api/events returned 200 text/event-stream; removed config, health, and agent-detail fields were absent.
  • WebKit browser.goto plus waitForSelector -> 13 retained pages returned 200 and rendered their checked surfaces: /, /tasks, /workflows, workflow detail, /galaxy, /jobs, /agents, agent detail, /org, /charts, /health, /config, /attention. No retired endpoint requests observed. Initial Jobs selector was incorrect; actual Jobs table rendered seven rows.
  • WebKit browser navigation to /?run=run-noted-001, /learning, and /learning/skills -> each normalized to / and rendered Overview.
  • WebKit mobile viewport 390x844 at /agents/researcher -> retained config rendered; template, version-history, and ephemeral-footer elements absent. Screenshot: /tmp/omp-sshots-15cd5c2bb5c1d669.webp.

Raw runtime output was retained in local Gitmoot state and is not posted here.

@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e7cdd28e587bff-1

Decision: approved
Summary: Reviewed exact head de7f777 against c4573a5 only. The retired Config column is removed correctly; all remaining headers and cells align with the API response. Prior finding answered and resolved. No new correctness or design defects found in the delta. Build, vet, tests, JavaScript syntax, and browser checks passed. No repository files edited.

Findings

  • Resolved: Config table's retired Max bg column removed (P3)

Tests Run

  • PATH=/usr/local/go/bin:$PATH go build ./... -> passed at de7f777 using Go 1.26.4.
  • PATH=/usr/local/go/bin:$PATH go vet ./... -> passed.
  • PATH=/usr/local/go/bin:$PATH go test ./... -> passed; dashboard package ok, development command has no test files.
  • python3 HTMLParser extraction of web/dist/index.html's text/x-dc inline script | node --check -> passed with Node v20.9.0.
  • PATH=/usr/local/go/bin:$PATH go run ./cmd/gitmoot-dashboard-dev -addr 127.0.0.1:18099 -> started successfully; temporary server stopped after browser verification.
  • Browser /config inspection and assertions against GET /api/config -> passed: five expected headers, four correctly aligned agent rows, no retired field or column; screenshot /tmp/omp-sshots-15cd5d8d5cfcdc03.png.

Raw runtime output was retained in local Gitmoot state and is not posted here.

@jerryfane
jerryfane merged commit d0b784c into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant