refactor(runner-providers): centralize shared runner contracts - #5248
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
marked this pull request as ready for review
August 5, 2026 13:47
edersonbrilhante
force-pushed
the
refactor-shared-runner-contracts
branch
from
August 5, 2026 18:22
bcc60d9 to
a228752
Compare
Brend-Smits
reviewed
Aug 12, 2026
Brend-Smits
left a comment
Brend-Smits
left a comment
Contributor
There was a problem hiding this comment.
Small comment, I'm gonna deploy this now on my local environment to see if everything is still working correctly. Brb
Brend-Smits
previously approved these changes
Aug 12, 2026
Brend-Smits
left a comment
Brend-Smits
left a comment
Contributor
There was a problem hiding this comment.
Tested it locally and it's working like a charm!
Base automatically changed from
test-separate-control-plane-provider-tests
to
main
August 12, 2026 20:29
edersonbrilhante
force-pushed
the
refactor-shared-runner-contracts
branch
from
August 12, 2026 20:29
a228752 to
ec4a4f1
Compare
Brend-Smits
approved these changes
Aug 12, 2026
edersonbrilhante
added a commit
that referenced
this pull request
Aug 12, 2026
## Description - Rename the scale-up provider hook from `prepareGroup` to `resolveLabelsForRunners`. - Replace `PreparedScaleUpRunnerGroup` with `RunnerLabelResolution`, containing the resolved `runnerLabels` and provider-specific `state`. - Update control-plane orchestration, the EC2 provider, the provider template, registry expectations, and existing tests in place. - Preserve runtime behavior while making the plugin contract explicit: message labels are resolved into runner labels and state used for runner lookup and creation. ## Test Plan - Control-plane suite: 14 test files / 326 tests passed - Runner-provider suite: 10 test files / 270 tests passed - ESLint and Prettier passed for all changed files - Exact test-title inventory: 276 before and after, with no additions or removals - `git diff --check` Local TypeScript build validation remains blocked by the installed `@aws-sdk/client-ec2` declarations missing exports used throughout the existing EC2 sources; the same environment issue affects untouched code. ## Related Issues Stacked on #5248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RunnerType,RunnerInfo,ListRunnerFilters, andCreateRunnerResultcontracts in runner-provider core.RunnerInfoshape across control-plane and EC2, withid,githubRunnerId, and requiredownerandtypefields.runners.d.ts.scale-runners/types.tsand remove the redundant scale-up and scale-down provider type shims.Compatibility note
This PR intentionally normalizes the exported
listEC2Runnersresult fields frominstanceId/runnerIdtoid/githubRunnerIdand removes the legacy core type aliases. This differs from the compatibility approach initially described in #5247 and is included explicitly for review.Test Plan
cd lambdas && NX_DAEMON=false yarn test(all 8 projects passed)git diff --checkLocal TypeScript build validation remains blocked by the installed
@aws-sdk/client-ec2declarations missing exports used throughout the existing EC2 sources; the same environment issue affects untouched code.Related Issues
Closes #5247
Stacked on #5246