Skip to content

refactor(runner-providers): resolve labels for runners - #5250

Merged
edersonbrilhante merged 1 commit into
mainfrom
refactor-runner-label-resolution
Aug 12, 2026
Merged

refactor(runner-providers): resolve labels for runners#5250
edersonbrilhante merged 1 commit into
mainfrom
refactor-runner-label-resolution

Conversation

@edersonbrilhante

Copy link
Copy Markdown
Contributor

Description

  • Rename the scale-up provider hook from prepareGroup to resolveLabelsForRunners.
  • Replace PreparedScaleUpRunnerGroup with RunnerLabelResolution, containing the resolved runnerLabels and provider-specific state.
  • Update control-plane orchestration, the EC2 provider, the provider template, registry expectations, and existing tests in place.
  • Preserve runtime behavior while making the plugin contract explicit: message labels are resolved into runner labels and state used for runner lookup and creation.

Test Plan

  • Control-plane suite: 14 test files / 326 tests passed
  • Runner-provider suite: 10 test files / 270 tests passed
  • ESLint and Prettier passed for all changed files
  • Exact test-title inventory: 276 before and after, with no additions or removals
  • git diff --check

Local TypeScript build validation remains blocked by the installed @aws-sdk/client-ec2 declarations missing exports used throughout the existing EC2 sources; the same environment issue affects untouched code.

Related Issues

Stacked on #5248

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Brend-Smits
Brend-Smits previously approved these changes Aug 12, 2026
@edersonbrilhante
edersonbrilhante disabled the stack merge August 12, 2026 20:29
@edersonbrilhante
edersonbrilhante force-pushed the refactor-runner-label-resolution branch from 0e5e4fe to aaaaa64 Compare August 12, 2026 20:29
Base automatically changed from refactor-shared-runner-contracts to main August 12, 2026 21:19
@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner August 12, 2026 21:19
@edersonbrilhante
edersonbrilhante force-pushed the refactor-runner-label-resolution branch from aaaaa64 to 26666e1 Compare August 12, 2026 21:19
@edersonbrilhante
edersonbrilhante merged commit c9473e8 into main Aug 12, 2026
9 checks passed
@edersonbrilhante
edersonbrilhante deleted the refactor-runner-label-resolution branch August 12, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants