test(control-plane): separate orchestration tests from EC2 provider tests - #5246
Merged
edersonbrilhante merged 1 commit intoAug 12, 2026
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Brend-Smits
approved these changes
Aug 12, 2026
Brend-Smits
left a comment
Brend-Smits
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Way easier to consume now. Great work! :rocket:
edersonbrilhante
deleted the
test-separate-control-plane-provider-tests
branch
August 12, 2026 20:29
edersonbrilhante
added a commit
that referenced
this pull request
Aug 12, 2026
## Description - Define the provider-neutral `RunnerType`, `RunnerInfo`, `ListRunnerFilters`, and `CreateRunnerResult` contracts in runner-provider core. - Use one `RunnerInfo` shape across control-plane and EC2, with `id`, `githubRunnerId`, and required `owner` and `type` fields. - Keep EC2-specific inputs and the EC2 status-filter extension in `runners.d.ts`. - Consolidate control-plane type re-exports in `scale-runners/types.ts` and remove the redundant scale-up and scale-down provider type shims. - Update the existing tests in place without adding or removing test cases. ### Compatibility note This PR intentionally normalizes the exported `listEC2Runners` result fields from `instanceId`/`runnerId` to `id`/`githubRunnerId` and removes the legacy core type aliases. This differs from the compatibility approach initially described in #5247 and is included explicitly for review. ## Test Plan - `cd lambdas && NX_DAEMON=false yarn test` (all 8 projects passed) - Control-plane suite: 14 test files / 326 tests passed - Runner-provider suite: 10 test files / 270 tests passed - Focused scale-down contract, EC2 listing, and pool tests passed after the final type tightening - ESLint and Prettier passed for control-plane and runner-providers - Exact test-title inventory: 276 before and after, with no additions or removals - `git diff --check` Local TypeScript build validation remains blocked by the installed `@aws-sdk/client-ec2` declarations missing exports used throughout the existing EC2 sources; the same environment issue affects untouched code. ## Related Issues Closes #5247 Stacked on #5246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Production behavior is unchanged.
Test Plan
cd lambdas && yarn test(all 8 projects passed)git diff --checkRelated Issues
Closes #5236
Follow-up to #5234