Skip to content

Remove sidebar-position controls from plugin row menus - #2916

Open
brsbl wants to merge 19 commits into
mainfrom
bb/plugin-row-actions-v1-thr_ccffp4w2p2
Open

Remove sidebar-position controls from plugin row menus#2916
brsbl wants to merge 19 commits into
mainfrom
bb/plugin-row-actions-v1-thr_ccffp4w2p2

Conversation

@brsbl

@brsbl brsbl commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Plugin row menus still exposed sidebar visibility controls even though the unified Customize sidebar surface now owns navigation visibility and order. The dropdown, right-click menu, and compact drawer also did not share one complete set of plugin actions.

What changed

  • Gives plugin row dropdowns, context menus, and compact drawers the same focused actions: Open in split when available, View details, then Disable.
  • Removes plugin visibility and position controls from row-level menus; Customize sidebar remains their single owner.
  • Keeps direct plugin launching unchanged.
  • When the active plugin is disabled, returns to Extensions and refreshes installed plugin state.
  • Adds focused coverage for menu parity, action order and icons, split availability, details navigation, disable behavior, and the compact drawer.

Screenshots

Both comparisons use the Design Doctrine plugin, the same persisted dev data, and matched viewport and interaction states. Before is current main at 99c0ad718; after is this PR at 9fd2fb7c1.

Desktop before — main Desktop after — #2916
Desktop before: plugin row menu exposes Hide from sidebar Desktop after: plugin row menu exposes Open in split, View details, and Disable
Compact before — main Compact after — #2916
Mobile before: plugin drawer exposes Hide from sidebar Mobile after: plugin drawer exposes Open in split, View details, and Disable

How you verified

  • Remote CI passed on exact head 9fd2fb7c1: checks, app/server/integration/package tests, Linux and macOS package smoke, and version checks. The unrelated iOS and Node compatibility jobs were skipped by workflow conditions.
  • Drove the exact-head branch web app in Chrome for Testing 151.0.7922.71 at 1440×900 and compact touch 390×844.
  • Verified dropdown and right-click parity; Open in split creates a second pane; View details navigates correctly; disabling the active plugin returns to Extensions, persists the disabled state, and the QA fixture was restored afterward.
  • Verified the compact drawer exposes the same labels, icons, order, and grouping, closes after navigation, and produced no browser console or runtime errors.
  • Compared the cumulative diff with main: only PluginNavSidebarItems.tsx and its focused test change. git diff --check passed.
  • Per repository policy, CI-equivalent checks were not rerun locally.

BB-Thread-ID: thr_ccffp4w2p2

AGENT GENERATED

@brsbl brsbl changed the title Focus plugin row actions Remove sidebar-position controls from plugin row menus Sep 2, 2026
…on-v1-thr_ccffp4w2p2' into bb/plugin-row-actions-v1-thr_ccffp4w2p2

# Conflicts:
#	apps/app/src/components/plugin/PluginNavSidebarItems.test.tsx
#	apps/app/src/components/plugin/PluginNavSidebarItems.tsx
@brsbl
brsbl changed the base branch from bb/customizable-sidebar-navigation-v1-thr_ccffp4w2p2 to bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2 September 3, 2026 01:32
Base automatically changed from bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2 to main September 3, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant