Remove sidebar-position controls from plugin row menus - #2916
Open
brsbl wants to merge 19 commits into
Open
Conversation
…nto bb/plugin-row-actions-v1-thr_ccffp4w2p2
…nto bb/plugin-row-actions-v1-thr_ccffp4w2p2
…on-v1-thr_ccffp4w2p2' into bb/plugin-row-actions-v1-thr_ccffp4w2p2 # Conflicts: # apps/app/src/components/plugin/PluginNavSidebarItems.test.tsx # apps/app/src/components/plugin/PluginNavSidebarItems.tsx
…on-v1-thr_ccffp4w2p2' into bb/plugin-row-actions-v1-thr_ccffp4w2p2
…on-v1-thr_ccffp4w2p2' into bb/plugin-row-actions-v1-thr_ccffp4w2p2
brsbl
changed the base branch from
bb/customizable-sidebar-navigation-v1-thr_ccffp4w2p2
to
bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2
September 3, 2026 01:32
Base automatically changed from
bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2
to
main
September 3, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Plugin row menus still exposed sidebar visibility controls even though the unified Customize sidebar surface now owns navigation visibility and order. The dropdown, right-click menu, and compact drawer also did not share one complete set of plugin actions.
What changed
Open in splitwhen available,View details, thenDisable.Screenshots
Both comparisons use the Design Doctrine plugin, the same persisted dev data, and matched viewport and interaction states. Before is current
mainat99c0ad718; after is this PR at9fd2fb7c1.mainmainHow you verified
9fd2fb7c1: checks, app/server/integration/package tests, Linux and macOS package smoke, and version checks. The unrelated iOS and Node compatibility jobs were skipped by workflow conditions.Open in splitcreates a second pane;View detailsnavigates correctly; disabling the active plugin returns to Extensions, persists the disabled state, and the QA fixture was restored afterward.main: onlyPluginNavSidebarItems.tsxand its focused test change.git diff --checkpassed.BB-Thread-ID: thr_ccffp4w2p2