Clarify sidebar navigation above the thread list - #2915
Merged
Conversation
This was referenced Sep 2, 2026
brsbl
changed the title
brsbl
deleted the
bb/customizable-sidebar-navigation-v1-thr_ccffp4w2p2
branch
September 3, 2026 05:05
brsbl
added a commit
that referenced
this pull request
Sep 3, 2026
## Human comments ## What was wrong Built-in navigation and plugin pages were owned by separate sidebar regions. Users could not choose which destinations stayed visible or arrange them as one coherent navigation list, and compact layouts had no matching customization flow. ## What changed - Uses one persisted order for built-in navigation and plugin pages. - Adds a quiet Customize entry point on the New thread row. - Opens `Customize sidebar` as a desktop popover and an in-place compact mode with Back. - Lists every destination with the shared multi-select checkbox and a drag grip. - Applies visibility and order immediately. Hidden plugin pages remain launchable from Customize. - Keeps every destination's existing behavior, including modifier-click opening in a split. - Keeps all built-ins visible by default and shows the first three optional plugin pages for users without saved preferences. - Migrates legacy visibility preferences without overriding explicit choices. - Preserves compact thread-list state while Customize is open. - Leaves plugin-row action-menu cleanup to the next stack layer. ## Screenshots The before revision is parent PR #2915 at exact head `150e60aef`. The after revision is this PR at exact head `9f5e741aa`. Each comparison uses the same dev fixture and rendered viewport. | Before — parent #2915 | After — unified navigation at rest | |---|---| |  |  | | Desktop Customize — exact PR head | |---| |  | | Mobile before — parent #2915 | Mobile after — in-place Customize mode | |---|---| |  |  | ## How you verified - Drove exact head `9f5e741aa` in Chrome for Testing 151.0.7922.71 against the branch dev app. - Verified the complete desktop flow at 1440×1000 and the compact flow at 390×500; captured comparable evidence at 340×900 and 390×844. - Confirmed all built-ins remain visible when the saved order interleaves built-ins and plugins, while exactly three optional plugins are shown by default. - Confirmed first-use reorder preserves checked membership and that visibility and order persist across reloads. - Confirmed New thread, plugin pages, and Automations preserve modifier-click split behavior from Customize. - Confirmed Automations retains its plugin-row options and accessory behavior. - Confirmed compact Customize retains the same thread-list DOM node, scroll position, accessibility state, and focus when entering and returning with Back. - Confirmed compact plugin launch navigates and closes the sidebar. - Observed no browser exceptions, console errors, stale frames, or layout shifts in the changed flow. - Remote CI passed on the exact head. Per repository policy, CI-equivalent checks were not run locally. BB-Thread-ID: thr_ccffp4w2p2 > AGENT GENERATED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Search threads was visually reduced to a detached icon, so it did not read as a primary sidebar destination. The navigation and thread-list regions also ran together without a quiet boundary.
What changed
⌘Khint in a stable trailing slot, but reveals it only when the row is hovered or keyboard-focused. Compact touch layouts omit the hint.Screenshots
The before revision is the PR merge base. The after images are from exact head
150e60aef, using the same dev fixture and viewport.mainateeaaa3e8d150e60aefmainateeaaa3e8d150e60aefHow you verified
150e60aefin Chrome for Testing 151.0.7922.71.BB-Thread-ID: thr_ccffp4w2p2